WordPress.org

Make WordPress Core

Opened 5 years ago

Last modified 19 months ago

#39598 new defect (bug)

Twenty Seventeen: Can't scroll on iPhone 4

Reported by: superpoincare Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 4.7.1
Component: Bundled Theme Keywords: has-patch needs-testing needs-screenshots needs-refresh
Focuses: css Cc:

Description

If I visit wp-themes.com/twentyseventeen/ on iPhone 4 Safari with iOS 7.1, I can't swipe to scroll down and read/access the text.

It might be a general issue with touch devices, not just on iPhone 4 since the browser is high on HTML5 features and should work ideally.

Don't know how to show a demo of this. Anyone reading has to test it herself/himself to confirm.

Attachments (1)

39598.diff (533.4 KB) - added by maguiar 4 years ago.
Add media queries for header in small devices

Download all attachments as: .zip

Change History (14)

#1 @davidakennedy
5 years ago

  • Focuses ui removed
  • Keywords reporter-feedback added

@superpoincare Thanks for the report!

I wouldn't trust wp-themes.com for testing purposes. Can you reproduce this on the official demo? It's here: http://2017.wordpress.net/

#2 @davidakennedy
5 years ago

  • Summary changed from Can't scroll on Twenty Seventeen on iPhone 4 to Twenty Seventeen: Can't scroll on iPhone 4

#3 @superpoincare
5 years ago

Hi @davidakennedy

Yes same problem in that site. Can't do anything.

#4 @davidakennedy
5 years ago

Okay, thanks for testing @superpoincare! I'll see if I can dig into this further.

This ticket was mentioned in Slack in #themereview by davidakennedy. View the logs.


5 years ago

This ticket was mentioned in Slack in #core-themes by davidakennedy. View the logs.


5 years ago

This ticket was mentioned in Slack in #forums by hardeepasrani. View the logs.


5 years ago

#8 @davidakennedy
5 years ago

  • Keywords needs-patch added; reporter-feedback removed
  • Milestone changed from Awaiting Review to 4.8

Just noting that this is indeed a bug and was verified by a few others on the Theme Review team. It needs to be investigated further.

@maguiar
4 years ago

Add media queries for header in small devices

#9 @maguiar
4 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

Here's what happens, it's not that you can't scroll, but the header is too big for the parallax effect to be noticed. This is because the theme uses viewport units to set the height, which is buggy in iOS7.

Attached patch adds media queries with specified heights in pixels for these screen sizes.

#10 @adamsilverstein
4 years ago

  • Keywords needs-screenshots added

@maguiar thanks for working on a patch! wow, that is a bunch of css :) does this have any effect on more modern devices running newer iOs versions?

Some screencasts before and after would be helpful here as a visual record and to demonstrate the fix.

Last edited 4 years ago by adamsilverstein (previous) (diff)

This ticket was mentioned in Slack in #core by obenland. View the logs.


4 years ago

#12 @obenland
4 years ago

  • Milestone changed from 4.8 to Future Release

#13 @ianbelanger
19 months ago

  • Focuses css added
  • Keywords needs-refresh added

The attached patch includes some extra code that shouldn't be there, so I am marking this as needs-refresh. If the issue still exists, I would like to get it fixed in one of the next major releases.

Note: See TracTickets for help on using tickets.