filter meta array in wp_insert_user

[tharsheblows]

Could a filter be added to the $meta array before inserting it into usermeta?

I don't use some of the meta keys and looked and saw they're safe to delete, but realised I can't actually stop them from being set. The reason I'm asking is that count_users is getting very slow for me (I have 110k users), so I'm coming at that from a couple of different directions.

Thanks.

[tharsheblows]

add filter to meta array in wp_insert_user

[DrewAPicture]

Hi @tharsheblows, welcome to Trac!

The new filter you're suggesting will need ​hook docs to go along with it.

[tharsheblows]

Oops. I've added them in - let me know any typos / misunderstandings / mistakes. Thanks! :)

[tharsheblows]

add in hooks docs

[chriscct7]

This patch needs a refresh for the version in the doc hook and some sanity checks. Will get a revised patch up and going when I get a chance

[chriscct7]

version number bumps. Array sanity check before for loop

[chriscct7]

formatting

[chriscct7]

Looks good to go.

[DrewAPicture]

Fixed docs

[DrewAPicture]

31549.patch​ fixes some of the types and formatting in the hook docs. Otherwise look good to go.

[wonderboymusic]

I'm not sure I would cast to array - maybe check after for ! $meta and then set to array() - I'll think about it

php > $a = null;
php > $b = (array) $a;
php > var_dump( $b );
array(0) {
}
php > $a = false;
php > $b = (array) $a;
php > var_dump( $b );
array(1) {
  [0]=>
  bool(false)
}
php > 

[wonderboymusic]

In 33708:

In wp_insert_user(), add a filter: insert_user_meta, to filter a user's meta values and keys before the user is created or updated.

Props tharsheblows, chriscct7, DrewAPicture.
Fixes #31549.

[geminorum]

Since it's the same for inserting new user and updating one, there's no safe way to see if the empty meta such as description is actually initiated empty or must be deleted on this update.

thinking the whole point of the filter is to bypass saving empty meta upon registration.

suggesting pass full info to the filter, i.e. $update

[tharsheblows]

That makes more sense! I've added it in.

[tharsheblows]

add in $update to see if user is being created or updated

[boonebgorges]

In 34266:

Tell the insert_user_meta filter whether user is being updated.

insert_user_meta was introduced in [33708]. This changeset passes the
$update parameter to it.

Props tharsheblows, geminorum.
Fixes #31549.