WordPress.org

Making WordPress.org

Opened 11 months ago

Closed 11 months ago

Last modified 11 months ago

#5579 closed defect (fixed)

TemplateNotFound: Template "macros.html" not found

Reported by: Hareesh Pillai Owned by: dd32
Milestone: Priority: low
Component: Trac Keywords:
Cc:

Description

There's a link to API at the right top of the page. Clicking on the link throws Not Found error.

Details

While doing a GET operation on /rpc, Trac issued an internal error.

User agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.88 Safari/537.36

Change History (3)

#1 @dd32
11 months ago

  • Component changed from General to Trac
  • Owner set to dd32
  • Priority changed from normal to low
  • Status changed from new to accepted

Disabling that menu item globally seems reasonable (It's disabled on core.trac and build.trac).

I'll see if I can find the macros.html template that should be there too, for completeness, but I suspect it's not going to be of much benefit.

#2 @dd32
11 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 10590:

Trac: Disable the rpc (API) menu item globally for all trac instances, rather than just on core.trac.

Fixes #5579.

#3 @dd32
11 months ago

Just noting that macros.html was removed from Trac 1.2, 1.0 was the last version with it, I'm not sure why the templates we're using is referencing it, as I can't find any refs to it.

​https://trac.edgewall.org/browser/branches/1.0-stable/trac/templates/macros.html

It's probably got something to do with us using the old Trac templating library, something I don't have an urgent want to touch, and I don't think adding macros.html into our custom theme is a good idea (There's probably others that are missing anyway).

Removing the link is good enough for me.

Note: See TracTickets for help on using tickets.