WordPress.org

Make WordPress Core

Opened 2 weeks ago

Last modified 8 days ago

#53929 new defect (bug)

Update whatwg-fetch version to match the one in Gutenberg

Reported by: Hareesh Pillai Owned by:
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: needs-patch good-first-bug
Focuses: Cc:

Description

Core currently has whatwg-fetch v3.0.0. Gutenberg has the latest version (v 3.6.2) in the ​package-lock.json file.

Change History (4)

#1 @SergeyBiryukov
2 weeks ago

  • Component changed from General to Build/Test Tools
  • Milestone changed from Awaiting Review to 5.9

Introduced in [43719] / #45065.

#2 follow-up: @desrosj
10 days ago

  • Keywords good-first-bug added

Related #53078.

I was trying to recall the reason why I did not include this update in #53078, but it's not coming to mind. It may have been an oversight. WordPress no longer depends on this polyfill as of [50934].

Based on the ​release notes, it seems updating this should be straightforward and will bring the latest update of the library to anyone still utilizing it.

Just a note for the contributor creating a patch for this: the version of the script needs to bumped in wp-includes/script-loader.php as well. The package is compiled into a script registered under the wp-polyfill-fetch handle.

#3 in reply to: ↑ 2 @Hareesh Pillai
8 days ago

Thanks for sharing the details, @desrosj.

WordPress no longer depends on this polyfill as of [50934].

In addition to updating, should we also remove this script from loading by default? Perhaps we could open a new ticket for that.

#4 @desrosj
8 days ago

The script should continue to be registered so that plugins and themes can enqueue the script if desired, but it should no longer be enqueued anywhere in WordPress Core. If it is, then we should fix that as it's a bug.

Note: See TracTickets for help on using tickets.