Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Series of bugs and shortcomings faced during 5.9 go/no go prep #35662

Open
2 of 16 tasks
mtias opened this issue Oct 15, 2021 · 7 comments
Open
2 of 16 tasks

Series of bugs and shortcomings faced during 5.9 go/no go prep #35662

mtias opened this issue Oct 15, 2021 · 7 comments

Comments

@mtias
Copy link
Contributor

@mtias mtias commented Oct 15, 2021

Compiling a list of bugs, shortcomings, and enhancement ideas I run into when preparing for the go / no go demo.

There's a lot of small issues related to the roundtrip a ServerRender block needs to do for any change and a great showcase for why they should be avoided entirely for any interactive block.

Screeny.Video.14.Oct.2021.at.12.29.46.mov
  • Pressing shift + click within a rich-text block nested inside a group would lock you out of editing. This one is pretty frustrating.(#35668)
Screeny.Video.14.Oct.2021.at.18.41.39.mov
  • Navigation block new link would break with no visible signs of recovery — typing the name of the page would not bring the page up.

Generally can happen after leaving the page open for a little bit or interacting for a while. It's understandable connection might break, but there should be some feedback.

Screeny.Video.13.Oct.2021.at.20.28.05.mov
  • Site logo placeholder graphic is not rendered properly in the site editor.
  • The template dropdown has template parts with no names when they don't belong to an area. Reported in #35587.

image

  • Buttons inside groups are misaligned. (Might be theme related.)

image

  • Disabling theme editor styles in preferences makes some elements in the page load with default colors and not the current color scheme.

image

  • The sibling inserter repositioning, together with the animation, makes it jump around.
Screeny.Video.14.Oct.2021.at.18.31.43.mov

  • The amount of lines shown in the site editor to distinguish active focus, hover focus, current template part focus, etc, is wild. We need to reduce this.

image

  • There's also a weird dotted outline on the site block.

image

  • More blocks with dotted outlines that don't seem appropriate.

image

  • Search in navigation menus is super awkward. It should be possible to get an icon only button that expands inline or in an overlay. This should likely also be the default. The initial insertion state, in particular, is a terrible experience:

image

  • Menu settings (called Display) should come before the Typography supports and should probably not be in a panel at all (not collapsible).

  • Typography: default size looks "unset".

image

@MaggieCabrera
Copy link
Contributor

@MaggieCabrera MaggieCabrera commented Oct 15, 2021

There's also a weird dotted outline on the site block.

I suspect that is a Videomaker bug /cc @scruffian

@ntsekouras
Copy link
Contributor

@ntsekouras ntsekouras commented Oct 15, 2021

Typography: default size looks "unset".

Could we use a help text here if we have ToggleGroupControl and the value is set to default?

@scruffian
Copy link
Contributor

@scruffian scruffian commented Oct 15, 2021

Buttons inside groups are misaligned. (Might be theme related.)

This was fixed by Automattic/themes#4842

@jasmussen
Copy link
Contributor

@jasmussen jasmussen commented Oct 18, 2021

Site logo fixed in #35718.

The amount of lines shown in the site editor to distinguish active focus, hover focus, current template part focus, etc, is wild. We need to reduce this.

#35637 removes dotted lines on ancestors. That fixes, or starts work on it.

Search in navigation menus is super awkward. It should be possible to get an icon only button that expands inline or in an overlay. This should likely also be the default.

#35688 starts work on it. The issue is also tracked separately in #31127.

@youknowriad
Copy link
Contributor

@youknowriad youknowriad commented Oct 18, 2021

Disabling theme editor styles in preferences makes some elements in the page load with default colors and not the current color scheme.

I've been trying but failing to reproduce this one. Any more details?

@jasmussen
Copy link
Contributor

@jasmussen jasmussen commented Oct 18, 2021

I've been trying but failing to reproduce this one. Any more details?

I'm seeing it happen in my block theme when toggling the editor styles off in preferences:
colors

@noisysocks
Copy link
Member

@noisysocks noisysocks commented Oct 19, 2021

Pages List server-render component is ill-suited and needs to be converted to a proper editor block.

I can look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants