Skip to content

/ gutenberg

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation Screen: Menu item custom ACF options #31551

Open
amir2mi opened this issue May 6, 2021 · 3 comments
Open

Navigation Screen: Menu item custom ACF options #31551

amir2mi opened this issue May 6, 2021 · 3 comments
Labels
Backwards Compatibility Needs Technical Feedback Needs Testing [Feature] Navigation Screen [Package] Edit Navigation [Type] Plugin Interoperability
Projects
Navigation editor

Comments

@amir2mi
Copy link

@amir2mi amir2mi commented May 6, 2021 •
edited

Advanced Custom Fields (ACF) is a popular plugin which developers use for their themes.
It has the feature to add custom options to each menu item, therefore, users can customize that menu item and the theme will show the menu depends on that settings, these options can be menu item color, icon, and so on.
I found that the new Navigation editor does not support those custom options.

Classic navigation:
menu item custom options

New navigation:
new nav editor
@draganescu draganescu added this to Inbox in Navigation editor via automation May 6, 2021
@CreativeDive
Copy link
Contributor

@CreativeDive CreativeDive commented May 6, 2021

@elliotcondon
@elliotcondon
Copy link

@elliotcondon elliotcondon commented May 7, 2021

Hi all 👋.

Elliot here representing the Advanced Custom Fields plugin. We are very interested to know what plans are in place to handle backwards compatibility for the PHP wp_nav_menu_item_custom_fields action introduced in WP 5.4 allowing custom HTML to be added into menu items.

Please note that ACF is not the only plugin using this action 👍.
@getdave
Copy link
Contributor

@getdave getdave commented May 7, 2021

Thanks again for raising this @amir2mi.

@elliotcondon This is on the project board and we'll be testing this shortly in order to review ways in which we can support the wp_nav_menu_item_custom_fields action. Would you be interested in helping to test any PRs that relate to this feature?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Backwards Compatibility Needs Technical Feedback Needs Testing [Feature] Navigation Screen [Package] Edit Navigation [Type] Plugin Interoperability
Projects
Navigation editor
  
Inbox
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@draganescu @getdave @elliotcondon @CreativeDive @amir2mi