Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mobile] Accessibility Mark I - Button #14697

Merged
merged 2 commits into from
Apr 3, 2019
Merged

[Mobile] Accessibility Mark I - Button #14697

merged 2 commits into from
Apr 3, 2019

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Mar 29, 2019 •
edited
Loading

This PR improves the Accessibility features of the Button component.

To test:

@etoledom etoledom mentioned this pull request Mar 29, 2019
Merged
@etoledom etoledom requested a review from pinarol March 29, 2019 09:32
@etoledom etoledom self-assigned this Mar 29, 2019
@etoledom etoledom added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Mar 29, 2019
@etoledom etoledom marked this pull request as ready for review March 29, 2019 09:32
pinarol
pinarol approved these changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with steps on parent PR

Tug
Tug approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@Tug Tug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@etoledom etoledom merged commit 342961e into master Apr 3, 2019
@etoledom
Copy link
Contributor Author

etoledom commented Apr 3, 2019

Thank you both!

@etoledom etoledom deleted the rnmobile/accessibility-mark-i branch April 3, 2019 07:16
@youknowriad youknowriad added this to the 5.5 (Gutenberg) milestone Apr 12, 2019
This was referenced Apr 15, 2019
Merged
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tug Tug Tug approved these changes

@pinarol pinarol pinarol approved these changes

Assignees

@etoledom etoledom

Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
5.5 (Gutenberg)
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@etoledom @Tug @pinarol @youknowriad