WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 13 months ago

Last modified 12 months ago

#39943 closed enhancement (fixed)

Update jQuery UI to 1.12.x

Reported by: lexhair Owned by:
Milestone: 5.6 Priority: normal
Severity: normal Version: 4.7.2
Component: External Libraries Keywords: has-patch needs-testing close
Focuses: Cc:

Description

Some nice enhancements in the jQuery 1.12.x library over 1.11.4 (current bundled version). Was coding a form with the controlgroup widget in jQuery UI 1.12.x only to realize the bundled jQuery UI didn't support it. Wound up using the now deprecated buttonset widget so I'll have to go back eventually.

First ticket in a while for me. Keep up the great work!

Attachments (2)

39943.diff (1.2 KB) - added by Hareesh Pillai 2 years ago.
Update v1.11.4 to v1.12.1
39943.2.diff (450 bytes) - added by helen 12 months ago.

Download all attachments as: .zip

Change History (17)

#2 in reply to: ↑ 1 @lexhair
5 years ago

Replying to Presskopp:

this has been done, see https://core.trac.wordpress.org/changeset/37528

https://core.trac.wordpress.org/ticket/36533#comment:44

jQuery UI is still showing 1.11.4 in my installation.

#3 @brokenflipside
5 years ago

@Presskopp that ticket refers to jQuery, not to be confused with jQuery UI. Which is why @lexhair is reporting seeing ver. 1.11.4.

#4 @Presskopp
5 years ago

Oops - got me. So we should update the component, I'd assume..

#5 @HeavenCore
3 years ago

@Presskopp Is there any progress on this?

Wordpress is still shipping with jQuery-UI 1.11.4 (Mar 11, 2015)

This should really be upgraded to jQuery-UI 1.12.1 (Sep 14, 2016) to allow use of newer widgets (controlgroup, Checkboxradio) & implement the dozens of bugfixes from 1.12 & 1.12.1:

https://jqueryui.com/changelog/1.12.0/

#6 @adaldesign
3 years ago

jQuery UI before 1.12 is now listed as common vulnerability: http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2016-7103

In my specific case, this is causing a server security scan to fail (for eCommerce).

This ticket was mentioned in Slack in #core by presskopp. View the logs.


3 years ago

@Hareesh Pillai
2 years ago

Update v1.11.4 to v1.12.1

#8 @Hareesh Pillai
2 years ago

  • Keywords has-patch needs-testing added

Patch added to update jQuery UI to v1.12.1.

Link to the changelog: https://jqueryui.com/changelog/

Commits: https://github.com/jquery/jquery-ui/compare/1.11.4...1.12.1

#9 @Presskopp
2 years ago

Probably there would be some more to do, see https://core.trac.wordpress.org/changeset/31716

This ticket was mentioned in Slack in #core by bbjmarsh. View the logs.


2 years ago

#11 @Presskopp
15 months ago

  • Keywords close added

related #37110

We can continue here: #50564

#12 @helen
13 months ago

  • Milestone changed from Awaiting Review to 5.6
  • Resolution set to fixed
  • Status changed from new to closed

Closing as fixed on 5.6 after [49101].

@helen
12 months ago

#13 @aaroncampbell
12 months ago

39943.2.diff looks correct to me (verified locally)

#14 @helen
12 months ago

In 49774:

Update $_old_files for 5.6.

See #39943.

#15 @helen
12 months ago

In 49775:

Update $_old_files for 5.6.

See #39943.
Merges [49774] to the 5.6 branch.

Note: See TracTickets for help on using tickets.