Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Date Block #30573

Closed
jameskoster opened this issue Apr 7, 2021 · 11 comments
Closed

Comment Date Block #30573

jameskoster opened this issue Apr 7, 2021 · 11 comments

Comments

@jameskoster
Copy link
Contributor

@jameskoster jameskoster commented Apr 7, 2021

Here is an initial take on the design for the Comment Date block. This block should only be available in the Site Editor, and potentially only when editing certain templates (Index, Single, Singular, Page).

comment-date

Design feedback is politely requested for all aspects:

  • Icon
  • Placeholder when there is no context present
  • Toolbar actions
  • Inspector settings
  • Name
  • Description

Figma link here.

@annezazu
Copy link
Contributor

@annezazu annezazu commented Apr 7, 2021

@jameskoster thanks so much for this exploration! While you're exploring this, I wanted to loop in some feedback that came out of a stream from a contributor where she mentioned that the date selection is currently unstyled:

Screen Shot 2021-04-07 at 11 06 17 AM

Is this something you plan to address here? I wasn't able to see it in the figma file so wanted to check to be sure.

@jameskoster
Copy link
Contributor Author

@jameskoster jameskoster commented Apr 7, 2021

@annezazu I think that is a separate issue altogether. Looks like a bug in the Post Date block.

@annezazu
Copy link
Contributor

@annezazu annezazu commented Apr 7, 2021

Facepalm -- got my date blocks confused. Thank you. Sorry about that!

@paaljoachim
Copy link
Contributor

@paaljoachim paaljoachim commented Apr 20, 2021

Hi James

It looks like you have the added options needed for this block.
One thing. I assume it will use the same date style as the rest of the WP backend.
As the date will change depending on the WP settings date and time settings.

@jameskoster
Copy link
Contributor Author

@jameskoster jameskoster commented Apr 21, 2021

I assume it will use the same date style as the rest of the WP backend.

Yup, the date format option should be respected here. But as in the Post Date block, it should be customisable:

Screenshot 2021-04-21 at 09 43 24

@carolinan
Copy link
Contributor

@carolinan carolinan commented May 7, 2021

The first iteration of this block as "Post Comment Date" was added in #24854

@justintadlock
Copy link

@justintadlock justintadlock commented Jun 20, 2021

Noting that a common use case for the comment published date is to wrap it in the permalink for the comment. Maybe a "link to comment" would make for a good option.

@SantosGuillamot
Copy link

@SantosGuillamot SantosGuillamot commented Sep 21, 2021

Hello! 👋 I would like to wrap up all the issues related to the Post Comments block to start working on a Comment Loop block as explained in this tracking issue. I'd like to make a quick summary to ensure we are aligned on this one:

Description

Add the date of the specific comment.

Potential Settings

  • Typography: It should be the same as the Post Date Block.
  • Color Settings: It should be the same as the Post Date Block.
  • Format Settings: It should be the same as the Post Date Block.
  • Link Settings:
    • Link to comment: Clicking the date will take the user to the comment URL.

References

Of course, any feedback is welcome 🙂

@gziolo
Copy link
Member

@gziolo gziolo commented Oct 7, 2021

I see that #35112 for Link Settings is close to ready. @carolinan, do you plan to continue working on other enhancements that @SantosGuillamot proposed?

@carolinan
Copy link
Contributor

@carolinan carolinan commented Oct 7, 2021

After #35112 there is nothing left to do on the checklist. I only mentioned that it was a partial pull request because it can't be tested inside a comment template /comment loop yet.

@gziolo
Copy link
Member

@gziolo gziolo commented Oct 7, 2021

That's awesome. Thank you for the clarification @carolinan. Let's close this issue once #35112 land then 😄

I wasn't aware that other features require only feature toggles. As simple as that 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

7 participants