THEME: Trees – 1.0

[GaryKay]

Trees - 1.0

Trees is an open canvas. Create!

Theme URL - ​http://roomworksmedia.com/
Author URL - ​http://roomworksmedia.com/

SVN - ​https://themes.svn.wordpress.org/trees/1.0
ZIP - ​https://wordpress.org/themes/download/trees.1.0.zip?nostats=1

History:

Ticket	Summary	Status	Resolution	Owner
#19787	THEME: treestruct - 1.0.0	closed	not-approved	gpriday
#21437	THEME: Treeson - 0.0.9	closed	not-approved	catchthemes
#23467	THEME: Trees – 1.0	closed	not-approved	aprakasa
(this ticket)
#23550	THEME: Treeson – 0.1.4	closed	live	kevinhaig
#26248	THEME: Treeson – 0.1.5	closed	live	kevinhaig
#26426	THEME: Treeson – 0.1.6	closed	live	jcastaneda
#26708	THEME: Treeson – 0.1.7	closed	live	jcastaneda
#26954	THEME: Treeson – 0.1.8	closed	live	jcastaneda
#27115	THEME: Treeson – 0.1.9	closed	live	jcastaneda
#27235	THEME: Treeson – 0.1.10	closed	live	jcastaneda
#27450	THEME: Treeson – 0.1.11	closed	live	catchthemes

Hi @GaryKay,

There are lot of thing's that need to be fixed.
Please take a look again at theme requirement guideline ​https://make.wordpress.org/themes/handbook/review/required/

REQUIRED:

No disabling of the admin tool bar.
https://themes.trac.wordpress.org/browser/trees/1.0/functions.php#L232

Screenshot.png should be of the actual theme as it appears with default options, not a logo or mockup.
https://themes.trac.wordpress.org/browser/trees/1.0/screenshot.png

Don't include any plugins
https://themes.trac.wordpress.org/browser/trees/1.0/tgm/plugins/woocommerce-menu-bar-cart.zip

No hard coding of scripts, styles and Favicons unless a browser workaround script. Everything should be enqueued
https://themes.trac.wordpress.org/browser/trees/1.0/header.php#L25
https://themes.trac.wordpress.org/browser/trees/1.0/header.php#L26
https://themes.trac.wordpress.org/browser/trees/1.0/header.php#L27
https://themes.trac.wordpress.org/browser/trees/1.0/header.php#L29
https://themes.trac.wordpress.org/browser/trees/1.0/header.php#L30
https://themes.trac.wordpress.org/browser/trees/1.0/footer.php#L64

Use get_template_directory() rather than TEMPLATEPATH to return the template path.
https://themes.trac.wordpress.org/browser/trees/1.0/index.php#L34
https://themes.trac.wordpress.org/browser/trees/1.0/single.php#L17
https://themes.trac.wordpress.org/browser/trees/1.0/single.php#L29

Missings textdomain
https://themes.trac.wordpress.org/browser/trees/1.0/tgm/rwrequired.php#L110
https://themes.trac.wordpress.org/browser/trees/1.0/tgm/rwrequired.php#L111
https://themes.trac.wordpress.org/browser/trees/1.0/tgm/rwrequired.php#L112
https://themes.trac.wordpress.org/browser/trees/1.0/tgm/rwrequired.php#L113
https://themes.trac.wordpress.org/browser/trees/1.0/tgm/rwrequired.php#L114
https://themes.trac.wordpress.org/browser/trees/1.0/tgm/rwrequired.php#L115
https://themes.trac.wordpress.org/browser/trees/1.0/tgm/rwrequired.php#L116
https://themes.trac.wordpress.org/browser/trees/1.0/tgm/rwrequired.php#L117
https://themes.trac.wordpress.org/browser/trees/1.0/tgm/rwrequired.php#L118
https://themes.trac.wordpress.org/browser/trees/1.0/tgm/rwrequired.php#L119
https://themes.trac.wordpress.org/browser/trees/1.0/tgm/rwrequired.php#L120
https://themes.trac.wordpress.org/browser/trees/1.0/404.php#L27

Not hooked
https://themes.trac.wordpress.org/browser/trees/1.0/functions.php#137
https://themes.trac.wordpress.org/browser/trees/1.0/functions.php#138
https://themes.trac.wordpress.org/browser/trees/1.0/functions.php#140
https://themes.trac.wordpress.org/browser/trees/1.0/functions.php#210

No more than 2 unique theme slugs. There 5 in here

option-tree-theme
tgmpa
trees
text_domain
my-text-domain

Please be sure address these issues.

Thank you, will get on to it shortly.

Updated theme as per review

Hi again @GaryKay,

Thank you for the update! You'll find theme review results below. Please note, that this is not a full review, due to the amount of issues found in a cursory overview.

REQUIRED

CODE

• No hard coding of scripts, styles and favicons unless a browser workaround script. Everything should be enqueued. I still found it header.php line 19 and 28
• Prefixing custom functions and filter is a must and be consistent with theme slug. These what I found inconsistent and unprefixed my_theme_wrapper_start(), my_theme_wrapper_end(), load_jquery(), wpex_pagination(), set_tag_cloud_sizes(), the_meeting_room_custom_background_args
• All strings should be wrapped in a ​gettext function. Please make sure to include text domain as well. Missing text domain at comments.php line 85, 97, 113, inc/meta.php line 5, 404.php line 18
• Wrong hook at functions.php line 241, 323
• PHP error at archive.php line 20
• All add_theme_support should be setup and registered within a theme specific setup function tied to the after_setup_theme action. I found register_nav_menus isn't hooked there functions.php line 194.
• Theme options must be stored as a single array, should be sanitized on input, and escaped on output.
• Themes must use ​sane default and don’t write default setting values to the database. I found d these

CSS

• CSS Do not use global anchor tag color with !important because it will make admin tool unreadable.
• Unstyling sidebar, I suggest to use ​Widget Monster to give a better view which one is missing.
• Unstyling post format but the theme has support for 'status', 'quote', 'gallery', 'image', 'video', 'audio', 'link', 'aside', 'chat' post format.

Notes

Please don't misunderstood "Don't include any plugins". You can use TGM-Plugin-Activation but host the plugins somewhere else ( e.g ​https://wordpress.org/plugins/ ), not inside the theme folder.

Licensing

• Please include copyright and license for the images. The theme should be 100% GPL-compatible

RECOMMENDED

My general conclusion, is that the code is pretty outdated. My recommendation would be for you to start over, preferably with an up-to-date starter theme, like ​Underscores.

CONCLUSION

Please fix above issues and ​upload new version of your theme, I'll leave this ticket open for another 2-3 days. Feel free to ask if you have any questions.

Hi @aprakasa ,

I will take your recomendations. Please close this ticket. I will start over and upload a new version.

Thank you for your time

Hi @GaryKay,

Ok, your welcome.