THEME: Shprink One - 1.1.0

[shprink]

Shprink One - 1.0.4

ShprinkOne is a responsive theme that can fit any screen (Mobile phone, tablet, laptop, desktop). Features a theme picker (more then 10 choices), a slideshow on the home page, posts as pins(masonry), infinite posts scroll, several Widget and Menu positions and multi language support. ShprinkOne is an Open Source project that can be forked on GitHub ​https://github.com/shprink/Shprink-One

Theme URL - ​http://julienrenaux.fr/shprinkone
Author URL - ​http://julienrenaux.fr

SVN - ​http://themes.svn.wordpress.org/shprink-one/1.0.4
ZIP - ​http://wordpress.org/themes/download/shprink-one.1.0.4.zip?nostats=1

Diff with previous version: ​http://themes.trac.wordpress.org/changeset?old_path=/shprink-one/1.0.3&new_path=/shprink-one/1.0.4

History:

Ticket	Summary	Status	Resolution	Owner
#12104	THEME: Shprink One - 1.0.2	closed	closed-newer-version-uploaded
#12259	THEME: Shprink One - 1.0.3	closed	not-approved	saymar90
#13071	THEME: Shprink One - 1.1.0	closed	not-approved	saymar90
(this ticket)
#13640	THEME: Shprink One - 1.2.0	closed	not-approved	saymar90
#14757	THEME: Shprink One - 2.0.1	closed	live	tubiz
#15307	THEME: Shprink One - 2.1.0	closed	live	chipbennett
#16255	THEME: Shprink One - 2.2.0	closed	live	jcastaneda
#16596	THEME: Shprink One - 2.3.2	closed	live	robin90
#20593	THEME: Shprink One - 2.4.1	closed	live	emiluzelac

Log:
Adding Flaty as the default template.
Adding a third level to all menus.
Adding “Previous” and “Next” buttons to posts.
Adding a specific “image.php” to display JPEG, GIF and PNG attachments.
CSS Non-breaking properties on Titles, Comments, Tags, Categories and Content.

Shprink One - 1.0.5

ShprinkOne is a responsive theme that can fit any screen (Mobile phone, tablet, laptop, desktop). Features a theme picker (more then 10 choices), a slideshow on the home page, posts as pins(masonry), infinite posts scroll, several Widget and Menu positions and multi language support. ShprinkOne is an Open Source project that can be forked on GitHub ​https://github.com/shprink/Shprink-One

Theme URL - ​http://julienrenaux.fr/shprinkone
Author URL - ​http://julienrenaux.fr

SVN - ​http://themes.svn.wordpress.org/shprink-one/1.0.5
ZIP - ​http://wordpress.org/themes/download/shprink-one.1.0.5.zip?nostats=1

Diff with previous version: ​http://themes.trac.wordpress.org/changeset?old_path=/shprink-one/1.0.4&new_path=/shprink-one/1.0.5

History:

Ticket	Summary	Status	Resolution	Owner
#12104	THEME: Shprink One - 1.0.2	closed	closed-newer-version-uploaded
#12259	THEME: Shprink One - 1.0.3	closed	not-approved	saymar90
#13071	THEME: Shprink One - 1.1.0	closed	not-approved	saymar90
(this ticket)
#13640	THEME: Shprink One - 1.2.0	closed	not-approved	saymar90
#14757	THEME: Shprink One - 2.0.1	closed	live	tubiz
#15307	THEME: Shprink One - 2.1.0	closed	live	chipbennett
#16255	THEME: Shprink One - 2.2.0	closed	live	jcastaneda
#16596	THEME: Shprink One - 2.3.2	closed	live	robin90
#20593	THEME: Shprink One - 2.4.1	closed	live	emiluzelac

I fixed a problem when the number of posts in the home page (total number of posts published) was less than 3 (number of posts displayed in the slideshow).
Thanks,
Julien

Shprink One - 1.1.0

ShprinkOne is a responsive theme that can fit any screen (Mobile phone, tablet, laptop, desktop). Features a theme picker (more then 10 choices), a slideshow on the home page, posts as pins(masonry), infinite posts scroll, several Widget and Menu positions and multi language support. ShprinkOne is an Open Source project that can be forked on GitHub ​https://github.com/shprink/Shprink-One

Theme URL - ​http://julienrenaux.fr/shprinkone
Author URL - ​http://julienrenaux.fr

SVN - ​http://themes.svn.wordpress.org/shprink-one/1.1.0
ZIP - ​http://wordpress.org/themes/download/shprink-one.1.1.0.zip?nostats=1

Diff with previous version: ​http://themes.trac.wordpress.org/changeset?old_path=/shprink-one/1.0.5&new_path=/shprink-one/1.1.0

History:

Ticket	Summary	Status	Resolution	Owner
#12104	THEME: Shprink One - 1.0.2	closed	closed-newer-version-uploaded
#12259	THEME: Shprink One - 1.0.3	closed	not-approved	saymar90
#13071	THEME: Shprink One - 1.1.0	closed	not-approved	saymar90
(this ticket)
#13640	THEME: Shprink One - 1.2.0	closed	not-approved	saymar90
#14757	THEME: Shprink One - 2.0.1	closed	live	tubiz
#15307	THEME: Shprink One - 2.1.0	closed	live	chipbennett
#16255	THEME: Shprink One - 2.2.0	closed	live	jcastaneda
#16596	THEME: Shprink One - 2.3.2	closed	live	robin90
#20593	THEME: Shprink One - 2.4.1	closed	live	emiluzelac

How is going with the review saymar?

Do you need anything from me?

Theme Check Recommendation

• No reference to add_theme_support( 'custom-header', $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
• No reference to add_theme_support( 'custom-background', $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.

Theme Unit Test

• Fixed: Sticky post should be distinctly recognizable in some way in comparison to normal posts. You can style the .sticky class if you are using the post_class() function to generate your post classes, which is a best practice.
• Fixed: Sticky post should show at the very top of the blog index page, even though they could be several posts back chronologically.
• Fixed: Non-breaking text in the title, content, and comments should have no adverse effects on layout or functionality. See attachment ​Post with long title.png​. The following CSS properties will help you support non-breaking text.

  -ms-word-wrap: break-word;
  word-wrap: break-word;
  

• Fixed: Post should have previous and next post link.
• Fixed: Third level menu don't work properly.
• Fixed: Attachment should have a previous, next attachement and a return to gallery link.
• Fixed: Header don't display properly when the admin bar is enabled. See attachment ​Header.png
• Not Fixed: Clearing Floats don't work properly.
• Not Fixed: Page with comments disabled doesn't display a “comments are closed” type message.

Debug Error

• Undefined index: theme_slideshow on line 142 of /wp-content/themes/shprink-one/admin/functions.php

Some Recommendations

• For Page with comments disabled, you could replace line 56 in comments.php by

  if ( !comments_open() && !is_page() ) :
  

• For Clearing Floats, you could add this CSS property clear: both; to #comments

Hi Saymar,

I made the changes ​http://themes.trac.wordpress.org/ticket/13640

Good luck and thanks again for your reviews,
Julien