Fix: SandBox component does not work outside WordPress context. #15415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
jorgefilipecosta
requested review from
aduth,
ajitbohra,
chrisvanpatten,
gziolo,
noisysocks,
talldan and
youknowriad
as code owners
jorgefilipecosta
force-pushed
the
fix/sandbox-component-does-not-work-outside-wordpress-context
branch
from
b07fb29
to
67de22f
Compare
Co-Authored-By: jorgefilipecosta <[email protected]>
jorgefilipecosta
deleted the
fix/sandbox-component-does-not-work-outside-wordpress-context
branch
sbardian
pushed a commit
to sbardian/gutenberg
that referenced
this issue
Jul 29, 2019
…Press#15415) The sandbox component resizing logic required the iframe to have a style setting the widget to 100%. In the block editor context, things worked as expected because the block styles include a style that sets iframes to 100%.
dd32
pushed a commit
to dd32/gutenberg
that referenced
this issue
Sep 27, 2019
…Press#15415) The sandbox component resizing logic required the iframe to have a style setting the widget to 100%. In the block editor context, things worked as expected because the block styles include a style that sets iframes to 100%.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
Fixes: #8565
The sandbox component resizing logic required the iframe to have a style setting the widget to 100%. In the block editor context, things worked as expected because the block styles include a style that sets iframes to 100%.
gutenberg/packages/block-library/src/style.scss
Lines 162 to 164 in 5430dce
The component should not rely on this style being available.
This PR makes sure the component sets the style it needs.
How has this been tested?
I pasted the content available on this gist https://gist.github.com/jorgefilipecosta/94673924b3c426f2a0cb3c7fa179a984 on the playground playground/src/index.js.
I verified I could read the "Content" string.