Opened 4 years ago
Closed 4 years ago
#30764 closed theme (live)
THEME: E-Comme – 1.0.6
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | new theme | Keywords: | theme-e-comme |
| Cc: | themesapollo@…, emiluzelac |
Description
E-Comme - 1.0.0
desc descdesc descdesc descdesc descdesc descdesc descdesc descdesc descdesc descdesc descdesc descdesc descdesc descdesc descdesc descdesc descdesc descdesc descdesc descdesc descdesc desc
Theme URL - http://apollothemes.com/e-comme/
Author URL - http://apollothemes.com
SVN - https://themes.svn.wordpress.org/e-comme/1.0.0
ZIP - https://wordpress.org/themes/download/e-comme.1.0.0.zip?nostats=1
History:
Attachments (8)
Change History (41)
#2
@
4 years ago
- Summary changed from THEME: E-Comme – 1.0.0.1 to THEME: E-Comme – 1.0.1
E-Comme - 1.0.1
e-comme is multipurpose responsive, clean and uniqe WordPress Theme for any business purpose. e-comme have easy navigate customizer by this you can easily customize theme in just few clicks. This theme gives you awesome looking website just put you contents and its ready to go.
Theme URL -
Author URL - https://www.themefarmer.com
SVN - https://themes.svn.wordpress.org/e-comme/1.0.1
ZIP - https://wordpress.org/themes/download/e-comme.1.0.1.zip?nostats=1
Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=e-comme/1.0.0.1&new_path=e-comme/1.0.1
History:
#3
@
4 years ago
- Summary changed from THEME: E-Comme – 1.0.1 to THEME: E-Comme – 1.0.2
E-Comme - 1.0.2
e-comme is multipurpose responsive, clean and uniqe WordPress Theme for any business purpose. e-comme have easy navigate customizer by this you can easily customize theme in just few clicks. This theme gives you awesome looking website just put you contents and its ready to go.
Theme URL -
Author URL - https://www.themefarmer.com
SVN - https://themes.svn.wordpress.org/e-comme/1.0.2
ZIP - https://wordpress.org/themes/download/e-comme.1.0.2.zip?nostats=1
Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=e-comme/1.0.1&new_path=e-comme/1.0.2
History:
#4
@
4 years ago
- Cc emiluzelac added
Hi @emiluzelac,
Is this name allowed for theme as it conflict with our Theme (E-commerce)?
This ticket was mentioned in Slack in #themereview by meszarosrob. View the logs.
4 years ago
#8
@
4 years ago
- Resolution set to not-approved
- Status changed from reviewing to closed
Hello @ThemesApollo,
I started reviewing your theme.
The theme tags in style.css and description must match the what the theme actually does in respect to functionality and design.
You are using the following theme tags that don't match the requirements:
sticky-post
You need to have visually distinctive style for sticky posts.
editor-style
Even you have are calling the correct function:
add_editor_style(get_template_directory_uri()."/css/custom-style.css"); in functions.php (line 87).
The file you are referencing is not present.
flexible-header
You don’t have support for this in your theme.
add_theme_support( 'custom-header' );
rtl-language-support
There are some visual glitches which have to be fixed for the RTL version, for example, the paratheses in sidebar.
e-commerce
Since you are adding theme support for WooCommerce, we expect the site to integrate nicely with it.
add_theme_support( 'woocommerce' ); in functions.php (line 82)
Let us know if you still plan to support these theme tags, if you do, then please fix these issues.
Furthermore, there are some functionality issues.
Call to action:
Leaving the buttons empty does not hide the buttons.
Slider
There are two things I noticed:
- Slides are overlapping
- In case you don't select three slides (the max number you defined in the customizer), then some dummy image and data appears. There is no way to turn them off.
Footer widgets
There is no way not to add widgets to the footer since automatically inserting widgets when nothing is set for the widget area.
Since your footer is dark and the links are darkish blue it is really hard to read the texts.
Sidebar widgets
Theme's layout is breaking when certain widgets are added.
See the attached screenshot.
#9
@
4 years ago
hi @implenton
thank you for feedback.
we will fix the issues soon.
but why you closed this ticket.
This ticket was mentioned in Slack in #themereview by themefarmer. View the logs.
4 years ago
#12
@
4 years ago
- Resolution not-approved deleted
- Status changed from closed to reopened
@implenton can you proceed with an actual, full review please? FYI, design is recommend only, not a requirement. Now I do see that this is an unfinished theme, therefore in this case @ThemesApollo will need to address that.
If needed, see: https://make.wordpress.org/themes/2014/12/26/preliminary-theme-review-process/
#13
@
4 years ago
hi @emiluzelac @implenton
we will soon fix all design related or any other isses.
Thanks
#15
@
4 years ago
- Summary changed from THEME: E-Comme – 1.0.2 to THEME: E-Comme – 1.0.3
E-Comme - 1.0.3
e-comme is multipurpose responsive, clean and uniqe WordPress Theme for any business purpose. e-comme have easy navigate customizer by this you can easily customize theme in just few clicks. This theme gives you awesome looking website just put you contents and its ready to go.
Theme URL -
Author URL - https://www.themefarmer.com
SVN - https://themes.svn.wordpress.org/e-comme/1.0.3
ZIP - https://wordpress.org/themes/download/e-comme.1.0.3.zip?nostats=1
Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=e-comme/1.0.2&new_path=e-comme/1.0.3
History:
#16
@
4 years ago
- Summary changed from THEME: E-Comme – 1.0.3 to THEME: E-Comme – 1.0.4
E-Comme - 1.0.4
e-comme is multipurpose responsive, clean and uniqe WordPress Theme for any business purpose. e-comme have easy navigate customizer by this you can easily customize theme in just few clicks. This theme gives you awesome looking website just put you contents and its ready to go.
Theme URL -
Author URL - https://www.themefarmer.com
SVN - https://themes.svn.wordpress.org/e-comme/1.0.4
ZIP - https://wordpress.org/themes/download/e-comme.1.0.4.zip?nostats=1
Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=e-comme/1.0.3&new_path=e-comme/1.0.4
History:
#17
@
4 years ago
@ThemeFarmer @ThemesApollo ,
I am going to start reviewing version 1.0.4. Please don't add any new version.
Thanks.
#18
follow-up:
↓ 19
@
4 years ago
I see you removed from your style.css the following theme tags: sticky-post, flexible-header.
This way you are not required to implement these features.
The requirements for sticky-post and rtl-language-support are done.
That clears every issue regarding theme tags.
I also see you addressed the layout problems with WooCommerce, the illegibility for the footer links and with the sidebar. That is great.
Accessibility
You don't have the accessibility-ready theme tag, so you are not required to meet those criteria.
Pass.
No PHP or JS errors.
With debug mode and the developer toolbar I don't have any PHP errors, neither in the browser's console for JS.
Pass.
Have a valid DOCTYPE declaration and include language_attributes.
Pass.
No removing or modifying non-presentational hooks.
Pass.
Validate and/or sanitize untrusted data before entering into the database. All untrusted data should be escaped before output.
I am still checking, but it seems fine to me.
Must meet all Theme Check requirements
Pass.
Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, etc.
I see you prefixed everything with e_comme_
Pass.
Use WordPress functionality and features first, if available.
Pass.
Don’t include admin/feature pointers.
Pass.
No pay wall restricting any WordPress feature.
Pass.
No disabling of the admin toolbar.
Pass.
Use get_template_directory() rather than TEMPLATEPATH to return the template path.
Use get_stylesheet_directory() rather than STYLESHEETPATH to return the stylesheet path.
Pass.
Use *_url() template tags, rather than bloginfo() equivalents.
Pass.
Avoid hard coding to modify content. Instead, use function parameters, filters and action hooks where appropriate. For example wp_title should be modified using a filter.
Pass.
Able to have child themes made from them. (Child theme ready)
Pass.
Include comments_template().
Pass.
The theme tags in style.css and description must match the what the theme actually does in respect to functionality and design.
Pass because of the fixes you made.
Use template tags and action/filter hooks properly.
Pass.
The theme options should not be pseudo custom post types and save non-trivial user data. Non-design related functionality is not allowed.
Pass. No custom post types and bizarre data savings.
Any custom features, options or any limitations (for example menu restrictions), should be explained. Enough documentation should be provided.
Since the elements in the main navigation are not clickable when they have child elements, please mention that.
Not pass.
All theme text strings are to be translatable.
Seems fine to me. Pass.
Include a text domain in style.css
It is included. Pass.
Use a single unique theme slug – as the theme slug appears in style.css. If it uses a framework then no more than 2 unique slugs.
Pass. No framework.
Can use any language for text, but only use the same one for all text.
Pass. Everything is in English.
Be 100% GPL and/or 100% GPL-compatible licensed.
Pass.
Declare copyright and license explicitly. Use the license and license uri header slugs to style.css.
Pass.
Declare licenses of any resources included such as fonts or images.
Declared in the readme. Pass.
All code and design should be your own or legally yours. Cloning of designs is not acceptable.
I hope so. Pass.
Theme names must not use: WordPress, Theme.
Does not use. Pass.
Spell “WordPress” correctly in all public facing text: all one word, with both an uppercase W and P.
Pass.
Save options in a single array.
Pass.
Use sane defaults and don’t write default setting values to the database.
Please remove the demo content from the sliders.
Not pass.
Use edit_theme_options capability for determining user permission to edit options, rather than rely on a role (e.g. “administrator”), or a different capability (e.g. “edit_themes”, “manage_options”).
Pass.
Use the Customizer for implementing theme options.
Pass.
Don’t include any plugins. A theme can recommend plugins but not include those plugins in the theme code.
Pass.
The screenshot should be of the actual theme as it appears with default options, not a logo or mockup.
The screenshot you provided is not the default options. In order to have that look you have to set the template for the Front Page page to Home template.
Not Pass.
The screenshot should be no bigger than 1200 x 900px.
Pass
Don’t phone home without informed user consent. Make any collection of user data “opt-in” only and have a theme option that is set to disabled by default.
Pass.
No URL shorteners used in the theme.
Pass.
If the theme adds a footer credit link, there should only be one (link to WordPress does not count)
Pass.
No hard coding of scripts and styles unless a browser workaround script. Everything should be enqueued.
Everything is enqueued. Pass.
No minification of scripts or files unless provide original files.
Original files are also provied.
Pass.
Required to use core-bundled scripts rather than including their own version of that script. For example jQuery.
Pass.
Include all scripts and resources it uses rather than hot-linking. The exception to this is Google Fonts.
Only Google Fonts is used. Pass.
Custom template files should be called using get_template_part() or locate_template().
Pass.
Standard templates should be called by their respective function.
Pass.
Display the correct content according to the front page setting
Pass.
We are really close to make this theme live. Please correct the things that don't pass.
The slider is broken, that should be corrected too: http://quick.as/QRdnCndRa
I don't see why the glyphicons fonts are included in the fonts folder. Are you using those?
I am using: Version 51.0.2704.106 (64-bit) on 10.11.5 (15F34) OS X. I also checked with BrowserStack http://www.browserstack.com/ the problem is present on different systems and browser as well.
#19
in reply to:
↑ 18
@
4 years ago
Replying to implenton:
Any custom features, options or any limitations (for example menu restrictions), should be explained. Enough documentation should be provided.
Since the elements in the main navigation are not clickable when they have child elements, please mention that.
Not pass.
working good for us we are using theme theme unit test data. from https://codex.wordpress.org/Theme_Unit_Test. and you can check here https://app.hyfy.io/v/abSedaY336/
Use sane defaults and don’t write default setting values to the database.
Please remove the demo content from the sliders.
Not pass.
Please check the code we are not storing any value to data base. and we are using sane defaults. please confirm if it is still required.
The screenshot should be of the actual theme as it appears with default options, not a logo or mockup.
The screenshot you provided is not the default options. In order to have that look you have to set the template for the Front Page page to Home template.
Not Pass.
We think screenshot is ok. please confirm from key reviewer. or we can ask.
The slider is broken, that should be corrected too: http://quick.as/QRdnCndRa
we are still finding if there is any such issue and we ll fix that.
I don't see why the glyphicons fonts are included in the fonts folder. Are you using those?
glyphicons fonts are part of bootstrap it might give 404 error in console. but we can remove if you want.
Thanks
#20
@
4 years ago
I don't see why the glyphicons fonts are included in the fonts folder. Are you using those?
glyphicons fonts are part of bootstrap it might give 404 error in console. but we can remove if you want.
OK. Got it. It was included with wp_enqueue_style. Since this is by default how bootstrap includes it. I think it is acceptable.
Since the elements in the main navigation are not clickable when they have child elements, please mention that.
What I meant is that you can't click on "Level 1", "Level 2". It is not a problem. Might worth note it in the readme.
Please remove the demo content from the sliders.
Even if you are not storing in the database you are loading demo data that can not be removed.
https://wordpress.slack.com/archives/themereview/p1469202006000967
The screenshot should be of the actual theme as it appears with default options, not a logo or mockup.
My interpretation is that you need to show with default option. In the screenshot you are presenting the slider for which you have to select a page template. I don't think it is a big deal. I will ask a second opinion about this.
BTW that is not noted anywhere that you have to select a template. Please note it in the readme as well, maybe the user won't know that there is an option for that :).
Check that slider thing and add those two notes in the readme and we are good to go from my point of view.
#21
@
4 years ago
- Summary changed from THEME: E-Comme – 1.0.4 to THEME: E-Comme – 1.0.5
E-Comme - 1.0.5
e-comme is multipurpose responsive, clean and uniqe WordPress Theme for any business purpose. e-comme have easy navigate customizer by this you can easily customize theme in just few clicks. This theme gives you awesome looking website just put you contents and its ready to go.
Theme URL -
Author URL - https://www.themefarmer.com
SVN - https://themes.svn.wordpress.org/e-comme/1.0.5
ZIP - https://wordpress.org/themes/download/e-comme.1.0.5.zip?nostats=1
Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=e-comme/1.0.4&new_path=e-comme/1.0.5
History:
#22
@
4 years ago
- Summary changed from THEME: E-Comme – 1.0.5 to THEME: E-Comme – 1.0.6
E-Comme - 1.0.6
e-comme is multipurpose responsive, clean and uniqe WordPress Theme for any business purpose. e-comme have easy navigate customizer by this you can easily customize theme in just few clicks. This theme gives you awesome looking website just put you contents and its ready to go.
Theme URL -
Author URL - https://www.themefarmer.com
SVN - https://themes.svn.wordpress.org/e-comme/1.0.6
ZIP - https://wordpress.org/themes/download/e-comme.1.0.6.zip?nostats=1
Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=e-comme/1.0.5&new_path=e-comme/1.0.6
History:
#25
@
4 years ago
HI,
@implenton
@emiluzelac
footer.php - small html issue fixed. may be this creating html (slider or navigation) issues.
inc/themefarmer-customizer.php. new settings added , hide slider, recent products, and sale products.
function e_comme_fallback_page_menu updated now showing sub-menu and moved to inc/themefarmer-walker.php from inc/themefarmer-functions.php.
woocommerce.php sidebar removed.
Slider default data removed.
How to setup home page added in readme.txt
Please let me know if anything i need to do.
Thanks.
#27
@
4 years ago
Previous review looks good, however there's an unresolved Theme Check issue, please run it and remove .ds_store.
#29
@
4 years ago
Hi @emiluzelac
sorry it took time to respond.
.ds_store not getting what it is please can you tell me.
i did ThemeCheck test it it says four RECOMMENDED stuffs.
Thanks
#30
@
4 years ago
@ThemesApollo it no longer comes up, however I see this instead:
WARNING: The tag white has been deprecated, please remove it from your style.css header. WARNING: The tag responsive-layout has been deprecated, please remove it from your style.css header. WARNING: The tag blue has been deprecated, please remove it from your style.css header. WARNING: The tag black has been deprecated, please remove it from your style.css header.
E-Comme - 1.0.0.1
e-comme is multipurpose responsive, clean and uniqe WordPress Theme for any business purpose. e-comme have easy navigate customizer by this you can easily customize theme in just few clicks. This theme gives you awesome looking website just put you contents and its ready to go.
Theme URL -
Author URL - http://apollothemes.com
SVN - https://themes.svn.wordpress.org/e-comme/1.0.0.1
ZIP - https://wordpress.org/themes/download/e-comme.1.0.0.1.zip?nostats=1
Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=e-comme/1.0.0&new_path=e-comme/1.0.0.1
History:
(this ticket)