THEME: Banten IT - 1.3

[nurulimam]

Banten IT - 1.2

Clean theme for WordPress adapted from twentytwelve responsive theme that looks great on any device. Features include a blogazine custom style, front page template with its own widgets, styling for post formats on both index and single views, and an optional no-sidebar page template. Make it yours with a custom menu, header image, and background.

Theme URL - ​http://www.nurulimam.com/banten-it-free-premium-magazine-wordpress-theme
Author URL - ​http://www.nurulimam.com

SVN - ​http://themes.svn.wordpress.org/banten-it/1.2
ZIP - ​http://wordpress.org/themes/download/banten-it.1.2.zip?nostats=1

Diff with previous version: ​http://themes.trac.wordpress.org/changeset?old_path=/banten-it/1.1&new_path=/banten-it/1.2

History:

Ticket	Summary	Status	Resolution	Owner
#14844	THEME: Banten IT - 1.1	closed	not-approved	manish_gori
#15176	THEME: Banten IT - 1.3	closed	not-approved	life.object
(this ticket)

Assigned for a review to ​aaires

Some notes after theme review:

• Every file even if not a template file has the following lines: "Visit ​http://www.nurulimam.com/theme to more theme" credit link is included in the footer there is no need to have this extra advertisement even if it is as a comment and not visible to the end user.

• File magz.php has <link rel="pingback" href="​http://www.nurulimam.com/xmlrpc.php" /> it looks like this file is not included in any way and if thats the case should be removed. If it is included there is no need to have a pingback link to the developers website

• Enqueue styles are done with get_template_directory_uri() url to the file, they must be included via wp_enqueue_style()
• Scripts are not included wit the wp_enqueue_script() (see header.php)

• other css scripts than the main styleshhet are included in the header.php, they should be added through the hook wp_enqueue_scripts

• it's a good practice to indent the code custom-style.php it's almost impossible to read.

The major thing is that custom-style.php looks to be a copy paste from here ​http://themes.svn.wordpress.org/inline/1.2.6/lib/resources/post-template-setup.php although no credits are added on the readme.txt.

Some other functions on this file seams to have been copy pasted from a different resource. Also full javascript is included directly when it should be done on a .js file and then enqueued.

Our current process is to keep the ticket open to allow for developer response/resubmission, so that the review can be continued in the same ticket. So, let's keep this one open and allow time for developer response.

Banten IT - 1.3

Clean theme for WordPress adapted from twentytwelve responsive theme that looks great on any device. Features include a blogazine custom style, front page template with its own widgets, styling for post formats on both index and single views, and an optional no-sidebar page template. Make it yours with a custom menu, header image, and background.

Theme URL - ​http://www.nurulimam.com/banten-it-free-premium-magazine-wordpress-theme
Author URL - ​http://www.nurulimam.com

SVN - ​http://themes.svn.wordpress.org/banten-it/1.3
ZIP - ​http://wordpress.org/themes/download/banten-it.1.3.zip?nostats=1

Diff with previous version: ​http://themes.trac.wordpress.org/changeset?old_path=/banten-it/1.2&new_path=/banten-it/1.3

History:

Ticket	Summary	Status	Resolution	Owner
#14844	THEME: Banten IT - 1.1	closed	not-approved	manish_gori
#15176	THEME: Banten IT - 1.3	closed	not-approved	life.object
(this ticket)

Any update on this review?

Replying to chipbennett:

Any update on this review?

@chip, please assign it to me.

Review Summary:

• This is not a complete review.

Theme Plugin Test:

Plugin "Theme Check": Pass
Plugin "Debogger": Pass
Plugin "Log Deprecated Notices": None

Required Issues:

• Themes are required to be 100% GPL-licensed, or use a ​GPL-compatible license. This includes all PHP, HTML, CSS, images, fonts, icons, and everything else. All of the theme must be GPL-Compatible.
  • Creative Commons License for images is not GPL compatible.

• Themes must explicitly declare the copyright information and license declaration for bundled/derived code, resources including fonts and images in the Theme.
• Code derived/borrowed from another work (such as Twenty Eleven) must be referenced, with original copyright/license declared.
• Footer credit link must be either Theme URI or Author URI.
• Themes are REQUIRED to use matching text strings for link anchor text, alt text, and title text in footer credit link.
• Themes are required to enqueue all stylesheets and scripts, using wp_enqueue_style()/wp_enqueue_script(), and hooked into an appropriate hook via callback function, rather than hard-coding stylesheet/script links or tags in the template.
• Call to wp_head() must come immediately before closing HTML </head> tag.

Theme Recommendation:

• Not-Approved.
• Currently this Theme does not meet the minimum standards, please resolve all issues including listed above and feel free to resubmit your Theme. This was a preliminary review.
• The following information should be of assistance in getting your theme to meet all the criteria:
  • Theme Review - ​http://codex.wordpress.org/Theme_Review
  • Theme Unit Checklist - ​http://codex.wordpress.org/Theme_Unit_Test
  • Theme Development - ​http://codex.wordpress.org/Theme_Development
  • Theme-Check Plugin - ​http://wordpress.org/plugins/theme-check/

Thank you for your submission.

Have you planned to submit the new version ? so i will be able to continue the review.