WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#45732 closed defect (bug) (fixed)

Twenty Fourteen Button block link displayed with underscore

Reported by: bobbingwide Owned by: laurelfulford
Milestone: 5.0.3 Priority: normal
Severity: normal Version: 5.1
Component: Bundled Theme Keywords: has-patch needs-testing has-screenshots commit fixed-major
Focuses: Cc:

Description

At yesterday's WordPress Portsmouth Meetup a problem was raised concerning underscoring of links in the Button block. I reproduced it. And Laurel Fulford asked me to raise an issue.
In the Classic a link with the class of "button" does not have underscores.
With the Button block it does, but they disappear on hover.
For backward compatibility it would be better without the underscores.

Unwanted underscores on Button block link Twenty Fourteen theme

I also noticed that when you choose the Outline style then, with default colours it displays as White on White.

Attachments (3)

unwanted-underscoring-on-button-in-Twenty-Fourteen.jpg​ (119.5 KB) - added by bobbingwide 3 years ago.
Unwanted underscores on Button block link Twenty Fourteen theme
45732.patch​ (442 bytes) - added by laurelfulford 3 years ago.
twenty-fourteen-button-block-after.png​ (50.3 KB) - added by laurelfulford 3 years ago.
Twenty Fourteen - button block with patch

Download all attachments as: .zip

Change History (9)

@bobbingwide
3 years ago

Unwanted underscores on Button block link Twenty Fourteen theme

#1 @laurelfulford
3 years ago

  • Component changed from Themes to Bundled Theme
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 5.0.3
  • Owner set to laurelfulford
  • Status changed from new to assigned

Thank you for reporting this issue, @bobbingwide! The underscore definitely should not be there.

I also noticed that when you choose the Outline style then, with default colours it displays as White on White.

This part should be taken care of in the fix for #45541.

@laurelfulford
3 years ago

@laurelfulford
3 years ago

Twenty Fourteen - button block with patch

#2 @laurelfulford
3 years ago

  • Keywords has-patch needs-testing has-screenshots added; needs-patch removed

45732.patch​ should take care of the text underline on the button blocks.

#3 @netweb
3 years ago

  • Keywords commit added

#4 @laurelfulford
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44378:

Twenty Fourteen: Remove text decoration from button block.

The button block in Twenty Fourteen was incorrectly inheriting a text underline from the theme's link styles.

Props bobbingwide.
Fixes #45732.

#5 @SergeyBiryukov
3 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for merging to the 5.0 branch.

#6 @SergeyBiryukov
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 44423:

Twenty Fourteen: Remove text decoration from button block.

The button block in Twenty Fourteen was incorrectly inheriting a text underline from the theme's link styles.

Props bobbingwide.
Merges [44378] to the 5.0 branch.
Fixes #45732.

Note: See TracTickets for help on using tickets.