Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not archiving failure artifacts for flaky tests #35379

Merged
merged 1 commit into from Oct 6, 2021

Conversation

@kevin940726
Copy link
Member

@kevin940726 kevin940726 commented Oct 6, 2021

Description

Fix #35278.

If the tests passed with flaky tests, the step is considered to be successful, so we need to always run the archive step.

How has this been tested?

N/A

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
Copy link
Contributor

@tellthemachines tellthemachines left a comment

Let's try this!

@kevin940726 kevin940726 merged commit 0ae0bde into trunk Oct 6, 2021
20 checks passed
@kevin940726 kevin940726 deleted the fix/failure-artifacts-for-flaky-tests branch Oct 6, 2021
@github-actions github-actions bot added this to the Gutenberg 11.7 milestone Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants