Skip to content

/ gutenberg-mobile

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rounded image #2591

Merged
merged 5 commits into from Sep 3, 2020
Merged

Rounded image #2591

merged 5 commits into from Sep 3, 2020

Conversation

@lukewalczak
Copy link
Contributor

@lukewalczak lukewalczak commented Sep 2, 2020

Fixes WordPress/gutenberg#24489

Ref to gutenberg: WordPress/gutenberg#24544

To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.
lukewalczak added 2 commits Aug 13, 2020
@lukewalczak
Update ref to rnmobile/rounded-image
Loading status checks…
e488c1c
@lukewalczak
Update ref
Loading status checks…
f768ffe
@lukewalczak lukewalczak requested a review from geriux Sep 2, 2020
@lukewalczak lukewalczak self-assigned this Sep 2, 2020
@lukewalczak lukewalczak added this to the 1.37 milestone Sep 2, 2020
lukewalczak added 2 commits Sep 2, 2020
@lukewalczak
Merge branch 'develop' into rounded-image
869f4f1
@lukewalczak
Update ref
Loading status checks…
9589755
@peril-wordpress-mobile
Copy link

@peril-wordpress-mobile peril-wordpress-mobile bot commented Sep 2, 2020 •
edited

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!
@geriux
geriux approved these changes Sep 2, 2020
View changes
Copy link
Member

@geriux geriux left a comment

Approved via WordPress/gutenberg#24544 (review)
@lukewalczak
Update ref to master
Loading status checks…
a285f49
@lukewalczak lukewalczak merged commit e37148f into develop Sep 3, 2020
7 checks passed
7 checks passed
ci/circleci: Android Native Unit Tests Your tests passed on CircleCI!
Details
ci/circleci: Check Correctness Your tests passed on CircleCI!
Details
ci/circleci: Test Android Your tests passed on CircleCI!
Details
ci/circleci: Test Android on Device - Canaries Your tests passed on CircleCI!
Details
ci/circleci: Test iOS Your tests passed on CircleCI!
Details
ci/circleci: Test iOS on Device - Canaries Your tests passed on CircleCI!
Details
ci/circleci: gutenberg-mobile/Optional UI Tests Your job is on hold on CircleCI!
Details
@lukewalczak lukewalczak deleted the rounded-image branch Sep 3, 2020
@ceyhun ceyhun mentioned this pull request Sep 14, 2020
Merged
5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux

Assignees

@lukewalczak lukewalczak

Labels
[Type] Enhancement
Projects
None yet
Milestone
1.37
Linked issues

Successfully merging this pull request may close these issues.

[Mobile App] Introduce rounded style option to Image block
2 participants
@lukewalczak @geriux
You can’t perform that action at this time.