Skip to content

/ WordPress-Android

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/appbar refresh #12933

Merged
merged 147 commits into from Sep 15, 2020
Merged

Feature/appbar refresh #12933

merged 147 commits into from Sep 15, 2020

Conversation

@khaykov
Copy link
Member

@khaykov khaykov commented Sep 10, 2020 •
edited

This PR is for the completed AppBar refresh feature.

All commits (apart from release notes one) were already reviewed.

To test:

  • Just do an app walkthrough to confirm that nothing immediately catastrophic is happening.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
khaykov added 30 commits Jul 24, 2020
@khaykov
Updated base styles and added prominent toolbar dimensions.
cf07dc7
@khaykov
Prominent toolbar at my site fragment.
74d002c
@khaykov
Notification list appbar.
Loading status checks…
15477a1
@khaykov
Added utility method that returns RecyclerView from FilteredRecyclerV…
5fd57cf 
…iew.
@khaykov
Updated classes related to lift on scroll in ViewPager.
7a6abc4
@khaykov
Updated reader post list to work with lift on scroll.
25e17e3
@khaykov
Added more comments to ViewPagerFragment
Loading status checks…
526eabe
@khaykov
Renaming, Cleaning up.
Loading status checks…
d00e52b
@khaykov
Extracted styling values, removed empty line.
Loading status checks…
4a8a9ab
@khaykov
Removed unused import.
Loading status checks…
ace50a1
@khaykov
Bumped gravatar size to 40dp.
1484d07
@khaykov
Added tab bg with bottom divider.
dd32eb0
@khaykov
Fixed my site and notification fragment appbar status restoration
30dc0f8
@khaykov
Updated expanded title margin.
9c561a7
@khaykov
Fixed state restoration.
2a3e5e8
@khaykov
My site -> My Site
Loading status checks…
b0a619e
@khaykov
Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…
daa83bc 
…ss-Android into issue/base-appbar-styling
@khaykov
Hide line below tab layout on elevation.
ac03e7d
@khaykov
Resizing gravatar on scroll.
Loading status checks…
5b381ec
@khaykov
Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…
Loading status checks…
17bff46 
…ss-Android into issue/base-appbar-styling
@khaykov
Updated action mode colors.
cd14446
@khaykov
Updated site picker activity.
f139fa2
@khaykov
Updated plans screen.
923a529
@khaykov
Added missing full screen dialog fragment layout.
9ad9f52
@khaykov
Updated plans activity layout.
fd0e79f
@khaykov
Updated themes activity.
bb3f99b
@khaykov
Updated activity log.
32aee86
@khaykov
Fixed ripple color in appbar.
Loading status checks…
67dd128
@khaykov
Merge branch 'issue/base-appbar-styling' of https://github.com/wordpr…
08bc852 
…ess-mobile/WordPress-Android into issue/lift-on-scroll-pt1
@khaykov
Enforcing style of manually set nav buttons.
Loading status checks…
c8f9f64
khaykov and others added 9 commits Sep 4, 2020
@khaykov
Using correct disabled resource for toolbar disabled color.
d4ce767
@khaykov
Updated border of blavatar and avatar.
Loading status checks…
eb6ec0e
@khaykov
Improved touch area of site picker chevron.
c61c878
@khaykov
Removed obsolete comment.
Loading status checks…
8748016
@renanferrari
Merge pull request #12799 from wordpress-mobile/issue/global-appbar-t…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e25628f 
…weaks

AppBar tweaks
@khaykov
Fixe merge conflicts in ReaderFragment and PostListActivity
Loading status checks…
49bf453
@khaykov
Fixed lift on scroll in notification settings and liked by screen.
Loading status checks…
67c2d97
@planarvoid
Merge pull request #12743 from wordpress-mobile/issue/lift-on-scroll-pt4
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
abf670d 
AppBar refresh - Reader and Notifications
@khaykov
Updated release notes.
9a56fba
@khaykov khaykov added this to the 15.8 milestone Sep 10, 2020
@peril-wordpress-mobile
Copy link

@peril-wordpress-mobile peril-wordpress-mobile bot commented Sep 10, 2020 •
edited

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.
@peril-wordpress-mobile
Copy link

@peril-wordpress-mobile peril-wordpress-mobile bot commented Sep 10, 2020 •
edited

You can test the changes on this Pull Request by downloading the APK here.
@khaykov
Merge branch 'feature/appbar-refresh' of https://github.com/wordpress…
Loading status checks…
f64c4e2 
…-mobile/WordPress-Android into feature/appbar-refresh
@khaykov khaykov marked this pull request as ready for review Sep 10, 2020
@khaykov khaykov requested review from planarvoid, develric and renanferrari Sep 10, 2020
@khaykov
Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…
Loading status checks…
acc7e3a 
…ss-Android into feature/appbar-refresh

# Conflicts:
#	WordPress/src/main/res/values-night/styles.xml
#	WordPress/src/main/res/values/styles.xml
@renanferrari renanferrari self-assigned this Sep 15, 2020
@peril-wordpress-mobile
Copy link

@peril-wordpress-mobile peril-wordpress-mobile bot commented Sep 15, 2020

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@renanferrari
renanferrari approved these changes Sep 15, 2020
View changes
Copy link
Member

@renanferrari renanferrari left a comment

Really great job on this, it's looking pretty good! 👍

LGTM :shipit:
@renanferrari renanferrari merged commit a814784 into develop Sep 15, 2020
8 checks passed
8 checks passed
Peril Found some issues. Don't worry, everything is fixable.
Details
ci/circleci: Installable Build Your tests passed on CircleCI!
Details
ci/circleci: Optional Tests/Hold Your job is on hold on CircleCI!
Details
ci/circleci: WordPressUtils Connected Tests Your tests passed on CircleCI!
Details
ci/circleci: gutenberg-bundle-build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: strings-check Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
@renanferrari renanferrari deleted the feature/appbar-refresh branch Sep 15, 2020
@osullivanchris
Copy link

@osullivanchris osullivanchris commented Sep 16, 2020

Looking great 🤤
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renanferrari renanferrari

@planarvoid planarvoid

@develric develric

Assignees

@renanferrari renanferrari

Labels
[Type] Enhancement
Projects
None yet
Milestone
15.8
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@khaykov @osullivanchris @renanferrari @planarvoid
You can’t perform that action at this time.