Fix/updates backups timeout #1696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm still hitting fatal errors occasionally during the update process. In the screenshot it happened with Gutenberg, updating via "Dashboard > Updates > View details about... > Click install". During testing last week it was happening consistently but now it's only happening intermittently, so this PR is an improvement.
|
|
Thanks for the PR! Merged in https://core.trac.wordpress.org/changeset/51902. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PHP timeouts by moving the backup deletion & restore to the
shutdownaction.Processes running on
shutdownare immune to PHP timeouts, so moving them there allows them to run after the main process, without affecting the update.Trac ticket: https://core.trac.wordpress.org/ticket/54166#ticket
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.