WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 4 months ago

#53578 closed enhancement (fixed)

Remove unnecessary function_exists check in `get_the_block_template_html`

Reported by: walbo Owned by: jorbin
Milestone: 5.8 Priority: normal
Severity: normal Version: 5.8
Component: Editor Keywords: has-patch commit fixed-major
Focuses: Cc:

Description

In get_the_block_template_html there is a functions_exists on the function wp_filter_content_tags.

Core doesn't need the check and the fallback function is deprecated.

Change History (6)

This ticket was mentioned in ​PR #1461 on ​WordPress/wordpress-develop by ​walbo.
4 months ago

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/53578

#2 @jorbin
4 months ago

  • Owner set to jorbin
  • Status changed from new to assigned

#3 @audrasjb
4 months ago

Indeed, there's no need to verify if the function exists. Plus, I suppose it was introduced in Gutenberg before wp_make_content_images_responsive() was deprecated in WP 5.5.

Last edited 4 months ago by audrasjb (previous) (diff)

#4 @jorbin
4 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 51321:

Remove unnecessary function_exists check in get_the_block_template_html

WordPress can be confident that WordPress functions exist.

I forgot this function existed.
And I thought that it would fatal, but it didn't
And it was so nice
So peaceful and quiet
I forgot this function existed
It isn't love, it isn't hate, it's just indifference

Introduced in [51003].

Props walbo.
Fixes #53578. See #53176.

#5 @SergeyBiryukov
4 months ago

  • Keywords commit fixed-major added
  • Milestone changed from Awaiting Review to 5.8
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 5.8 consideration, seems good to backport to the branch.

#6 @jorbin
4 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 51325:

Remove unnecessary function_exists check in get_the_block_template_html

Merges [51321] to the 5.8 branch. Reviewed by SergeyBiryukov.

WordPress can be confident that WordPress functions exist.

I forgot this function existed.
And I thought that it would fatal, but it didn't
And it was so nice
So peaceful and quiet
I forgot this function existed
It isn't love, it isn't hate, it's just indifference

Introduced in [51003].

Props walbo.
Fixes #53578. See #53176.

Note: See TracTickets for help on using tickets.