Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Add instructions for installing plugins/themes with wp-env #35064

Merged
merged 1 commit into from Sep 23, 2021
Merged

Docs: Add instructions for installing plugins/themes with wp-env #35064

merged 1 commit into from Sep 23, 2021

Conversation

Reviewers

@Mamaduka Mamaduka

@noahtallen noahtallen

Assignees
No one assigned
Labels
First-time Contributor [Package] Env [Type] Documentation
Projects
None yet
Milestone
Gutenberg 11.7
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@AetherUnbound @Mamaduka
@AetherUnbound
Copy link
Contributor

@AetherUnbound AetherUnbound commented Sep 22, 2021

Description

This PR adds an example for installing plugins and themes using wp-env. I encountered an issue similar to wp-cli/wp-cli#3255, docker-library/wordpress#417 where I was unable to install plugins or themes. I've provided instructions for how to install plugins using the conventional wp-env method, as well as an alternate in case that does not work for some folks.

How has this been tested?

The additional command I provided was the only way I was able to install a plugin locally; I've tested that both themes and plugins can be installed with this method.

Screenshots

Types of changes

Small docs addition!

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

(I've left these unchecked since they don't appear to apply to documentation, but please let me know if there are any I should check/run)
@AetherUnbound AetherUnbound requested a review from noahtallen as a code owner Sep 22, 2021
@github-actions
Copy link

@github-actions github-actions bot commented Sep 22, 2021

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @AetherUnbound! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

Loading

Mamaduka
Mamaduka reviewed Sep 23, 2021
View changes
packages/env/README.md Outdated Show resolved Hide resolved
Loading
@AetherUnbound
Add instructions for installing plugins/themes
d04163c
@AetherUnbound AetherUnbound force-pushed the docs/wp-env-edge-case branch from 800f970 to d04163c Sep 23, 2021
Mamaduka
Mamaduka approved these changes Sep 23, 2021
View changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Thanks for working on this, @AetherUnbound.

Let's merge this PR once all checks are green ✅

Loading

@Mamaduka Mamaduka merged commit 0c3cbd0 into WordPress:trunk Sep 23, 2021
18 checks passed
Loading
@github-actions github-actions bot added this to the Gutenberg 11.7 milestone Sep 23, 2021
@AetherUnbound
Copy link
Contributor Author

@AetherUnbound AetherUnbound commented Sep 23, 2021

Fantastic, thanks for the quick turnaround! 🙌🏼

Loading

@AetherUnbound AetherUnbound deleted the docs/wp-env-edge-case branch Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment