Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ColorPicker #34284

Open
15 of 28 tasks
ciampo opened this issue Aug 25, 2021 · 0 comments
Open
15 of 28 tasks

Updated ColorPicker #34284

ciampo opened this issue Aug 25, 2021 · 0 comments

Comments

@ciampo
Copy link
Contributor

@ciampo ciampo commented Aug 25, 2021

This is an overview issue to track all of the tasks necessary to update the ColorPicker component with the new design and primitives.

image

Component

  • Add experimental ColorPicker component to the repo (done in #33714)
  • #34286
  • #34289
  • #34795
  • Match design proposal: (#34598)
    • Adjust the white border on the circle controls to match design (compare storybook with design mockup).
    • The input padding is off, not sure if this is something we need to affect on all inputs or we can just start with the input + slider case.
    • Spacing between slider and input is off.
    • #34288
    • Use the new settings icon from wp/icons.
    • the color format dropdown should be rendered without borders (not sure how we want to handle this at the component level since it should be an optional thing used rarely)
    • Adjust circular handle of slider since it's too big compared to designs
  • Follow-up tasks following previous design enhancement PR:
    • Redesign the input fields taking into consideration the new border color and height (removing specific height from this component).
    • Improve the RangeControl making the focus work on safari and implementing the new focus design.
    • Address the glitch with circle borders/shadows on chrome.
  • #34487
  • #35675
  • #35677

Integration

  • Add deprecated props adapter to transform the props for the "legacy" ColorPicker into the new format (done in #34014)
  • #34287
  • Enable Alpha and close #18095

Related issues

I've also found a list of open issues/PRs that will likely be closed (or should otherwise be fixed) as a consequence of the work carried out in the tasks above:

@ciampo ciampo added this to Inbox (needs triage) 📬 in WordPress Components via automation Aug 25, 2021
@ciampo ciampo moved this from Inbox (needs triage) 📬 to Backlog (triaged) 📝 in WordPress Components Aug 25, 2021
@ciampo ciampo changed the title Components: update ColorPicker to g2 [Tracking issue] Components: update ColorPicker to g2 Aug 25, 2021
@mtias mtias changed the title [Tracking issue] Components: update ColorPicker to g2 Updated ColorPicker Aug 25, 2021
@ciampo ciampo moved this from Backlog (triaged) 📝 to 🛤 Tracking issues in WordPress Components Aug 25, 2021
@mtias mtias mentioned this issue Aug 27, 2021
66 tasks
@jorgefilipecosta jorgefilipecosta self-assigned this Sep 1, 2021
@priethor priethor added this to 📥 To do in WordPress 5.9 Must-Haves via automation Oct 15, 2021
@priethor priethor moved this from 📥 To do to 🏗️ In progress in WordPress 5.9 Must-Haves Oct 15, 2021
@noisysocks noisysocks moved this from 🏗️ In progress to 📋 Overviews in WordPress 5.9 Must-Haves Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
WordPress Components
🛤 Tracking issues
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants