Skip to content

/ shell-command

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed PsySH initialization #49

Merged
merged 1 commit into from Oct 31, 2020
Merged

Fixed PsySH initialization #49

merged 1 commit into from Oct 31, 2020

Conversation

@claudiosanches
Copy link
Contributor

@claudiosanches claudiosanches commented Oct 15, 2020 •
edited

Hello! Thanks for this amazing project!

I found a small bug while trying to integrate with PsySH, seems like an incorrect command is used to initialize PsySH:

Screenshot from 2020-10-14 23-06-59

This happens because Psy\Shell::debug() is used to introduce breakpoints.

Note that Psy\Shell->run() is also used by all other integrations: https://github.com/bobthecow/psysh/wiki/Integrations
@claudiosanches
Fixed PsySH initialization
aff4226 
Note that Psy\Shell::debug() should be used to introduce breakpoints.
@claudiosanches claudiosanches requested a review from wp-cli/committers as a code owner Oct 15, 2020
@schlessera schlessera added this to the 2.0.6 milestone Oct 31, 2020
@schlessera
schlessera approved these changes Oct 31, 2020
View changes
@schlessera schlessera merged commit d29fced into wp-cli:master Oct 31, 2020
3 checks passed
3 checks passed
@github-actions
Lint PHP files
Details
@github-actions
PHPCS
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schlessera
Copy link
Member

@schlessera schlessera commented Oct 31, 2020

Thanks for the PR, @claudiosanches !

@claudiosanches claudiosanches deleted the claudiosanches:fix/psysh-init branch Nov 3, 2020
@claudiosanches claudiosanches restored the claudiosanches:fix/psysh-init branch Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlessera schlessera

Assignees
No one assigned
Labels
command:shell
Milestone
2.0.6
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@claudiosanches @schlessera