Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin-unit-tests.md #357

Merged
merged 3 commits into from May 14, 2021
Merged

Update plugin-unit-tests.md #357

merged 3 commits into from May 14, 2021

Conversation

@spicecadet
Copy link
Contributor

@spicecadet spicecadet commented Jun 4, 2020

Updated the title. Should the file name change as well?

Updated the title. Should the file name change as well?
@schlessera
Copy link
Member

@schlessera schlessera commented Jun 4, 2020

The content of the page should be adapted as well. However, the file name can't change, as that is just how the tool is currently being used.

As this might be misleading (talking about integration tests and using "unit-tests" for them), there should be a small paragraph that explains why that is:

  • the scaffolding uses the WordPress Core "unit tests" that serve to unit-test WordPress Core
  • they are useful for testing plugins and themes as well, but if they are used in that way, it turns those tests into "integration tests" - they test the integration between a plugin/theme and WordPress Core. Proper unit tests for a plugin or theme would not load WordPress.

Added clarification on unit tests and integration tests. Let me know if this needs to move or change.
plugin-unit-tests.md Outdated Show resolved Hide resolved
Co-authored-by: Alain Schlesser <[email protected]>
@schlessera schlessera added this to the 2.5.0 milestone May 14, 2021
@schlessera schlessera merged commit 9d9af59 into wp-cli:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants