Size Change: +4.79 kB (0%)

Total Size: 1.07 MB

_{compressed-size-action}

The only thing I'd like to double-check before approving the PR is if the none alignment value is being properly handled in the Image block. I noticed that the none/default alignment value for that block aligns the content to the left

@fluiddot this is a fantastic question. Thanks for bringing this up.

In regards to explicit code to "handle" a none alignment, currently it does not exist.

However, I would pose the question: what should the representation be for the none alignment?

From reviewing the web representation, it might imply that representing none with a left-aligned image in the editor would be expected, i.e. what we render currently in your example video. The following showcases the none and left alignment options in both the web editor and web preview.

Web Editor (top) vs Web Preview (bottom)

Alignment: None	Alignment: Left

Given that, I would say our two options are presenting none alignments either centered- or left-aligned. Currently, I think the latter may make the most sense and aligns with the web editor representation. WDYT?

Native Editor `none` Presentation

Center	Left

@fluiddot this is a fantastic question. Thanks for bringing this up.

In regards to explicit code to "handle" a none alignment, currently it does not exist.

Thanks for checking this ❤️ !

However, I would pose the question: what should the representation be for the none alignment?

From reviewing the web representation, it might imply that representing none with a left-aligned image in the editor would be expected, i.e. what we render currently in your example video. The following showcases the none and left alignment options in both the web editor and web preview.

Given that, I would say our two options are presenting none alignments either centered- or left-aligned. Currently, I think the latter may make the most sense and aligns with the web editor representation. WDYT?

Great investigation 💯 ! I agree that only center and left alignments fit what I would expect when having none alignment value. For the Image block, the current approach with content left-aligned makes sense to me as it matches the same behavior of the web version. It's interesting that this block is the only one that handles the none case this way, I noticed that the rest (Embed, Cover, etc.) by default display the content centered.

As a side note, while testing I spotted that the theme might affect the Image block as well, as an example, I used the theme Spearhead and the none value on the preview is centering the image 🤔 .

Web editor	Web Preview

Also curious about MenuGroup and any timelines for supporting it.

Just to learn a bit more, can you please share why MenuGroup and MenuItem are not supported in native? Is there any technical limitation with native?

Also curious about MenuGroup and any timelines for supporting it.

@ntsekouras @mtias in regards to lack of MenuGroup support, there is no technical limitation but likely originates from no specific mobile-centric UI or internal priority requiring it. My general understanding of the focus of internal mobile teams currently largely falls into two categories: increased block support and site/page editing features. So, I would imagine MenuGroup has just not been a necessity for those two categories so far.

Additionally, the mobile UI often leverages more platform-specific UI like our Cell components or native action sheets. There could be opportunity to encapsulate this platform-specific UI as mobile's version of MenuGroup/MenuItem, but maybe not. It could be the API is so divergent it does not make sense.

Cell and Action Sheets

In regards to a timeline for support, I would defer to @hypest, @mchowning, @antonis, and @iamthomasbishop to ask if they have any knowledge of plans to leverage a MenuGroup UI.

I interpret the inquiries regarding MenuGroup to be non-blocking, so I will move to merge this regression fix to avoid issues in our next mobile release. Thanks. 🙇🏻

It's not blocking now, but I want to stay as far away as we can from these platform divergences on shared components, because we are shipping extra code for anyone and just makes maintenance harder.

👋 thanks for the ping @dcalhoun!

There are no current plans for supporting MenuGroups, but now it's actually a good time to look into it. David has already pinged you above @iamthomasbishop but yeah, please collaborate with @dcalhoun to have a first assessment of such a project. Thanks!

I want to stay as far away as we can from these platform divergences on shared components, because we are shipping extra code for anyone and just makes maintenance harder.

I agree with @mtias , it's unfortunate to have to ship and maintain platform specific "forks", especially when they end up being divergent designs. I also understand how they come to be some times: a UI change on the web is merged without being tested on native mobile (at least for crashes) which puts the native mobile team in panic mode to fix the crash in any fast/dirty way they can. It'd be better if we get to collaborate before such merges happen, to at least test out native mobile when new UI is introduced (the "none" alignment option in this case).

@hypest I think we need more participation on the UI components side of things as well, since these are primitives that people making updates to blocks should not have to account for because they should have a representation cross-platform.