Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages: Update the note about using polyfill for ES2015+ features #34878

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Sep 16, 2021

Description

WordPress Core dropped support for IE 11 in the 5.8 release. At the same time we created a polyfill to ES2015+ features that better reflects the needs of the WordPress ecosystem knowing exactly the target supported browsers. Let's update README files in all packages to recommend the custom polypill that WordPress Core is using.

I see that Visual Studio Code triggered Prettier run on all modified files, but that can be ignored. We don't validate the file formatting in markdown files yet, so this is something that still happens from time to time.

Props to @ciampo for the copy update when improving the README file in @wordpress/components.

Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks Grzegorz! 💯

Copy link
Member

@diegohaz diegohaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🎉

@gziolo gziolo merged commit 65dd1e4 into trunk Sep 16, 2021
@gziolo gziolo deleted the update/packages-polyfill-note branch September 16, 2021 15:45
@github-actions github-actions bot added this to the Gutenberg 11.6 milestone Sep 16, 2021
@gziolo gziolo moved this from Needs review to Done in Core JS Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm Packages Related to npm packages [Type] Developer Documentation Documentation for developers
Projects
No open projects
Core JS
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants