Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Icons: Preset colors do not stay in sync with Global Styles presets #35480

Open
kjellr opened this issue Oct 8, 2021 · 0 comments
Open

Social Icons: Preset colors do not stay in sync with Global Styles presets #35480

kjellr opened this issue Oct 8, 2021 · 0 comments

Comments

@kjellr
Copy link
Contributor

@kjellr kjellr commented Oct 8, 2021

When you assign a preset color to the Social Links block, it records the preset's hex color in the markup like so:

<!-- wp:social-links {"iconColor":"foreground","iconColorValue":"#000000"} -->

If someone were to go and modify the value of that foreground preset via Global Styles, the social links block does not update to the new color value. The original hex color defined in the block markup is still used.

GIF:

Note that I'm changing the color of "foreground" via Global Styles, but that update is not reflected in the Social Links block color:

social-links-color


Gutenberg version 11.7.0-rc.1
Noticed during the development of Twenty Twenty-Two: WordPress/twentytwentytwo#74 (comment)

@kjellr kjellr changed the title Social Icons: Custom color does not stay in sync with Global Styles presets Social Icons: Preset colors do not stay in sync with Global Styles presets Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant