New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments Loop Block: Tracking issue #34994
Comments
We can start with a soft deprecation, i.e. supporting the old block but deprioritising it (e.g. hiding it from the inserter). In other words, we don't need formal deprecation notices yet. The fact that it's a dynamic block means that, later on, we have some flexibility to determine how existing Post Comments blocks should be rendered.
If the old blocks'
Yes, as I mentioned above — unless supporting both becomes an unreasonable burden!
IMO, it depends on what the benefits are, or what the use cases could be for this. It feels lower priority to me.
It's probably the trade-off between the flexibility of more granular blocks (Author + Avatar) vs. the user-friendliness and polish of dedicated multi-functional blocks (Author with integrated Avatar). With the ongoing improvements in layouts and alignments, the balance may soon tip towards granular blocks. I suggest experimenting with both and seeing what feels right. :) |
@SantosGuillamot One design update we might consider: the new Dimensions and Layout panels will be useful on blocks like Avatar, but potentially all of them.
Probably worth getting a theme dev's input here (cc @kjellr), but I suspect that the flexibility afforded by separate blocks for author name and author avatar will be more useful in general. |
Yeah, the current iteration of the Post Author block is pretty inflexible and limiting for theme authors. There was a lot of talk about its issues (and the idea of splitting it into sub-blocks) in #24952. This is one of the reasons the block was left out of 5.8. |
Author with integrated Avatar -sounds like a good default block pattern or a block with inner blocks. |
@SantosGuillamot these three blocks don't have design, so I'm going to label them with |
I agree it makes sense for most of these blocks |
I believe the Group block has already implemented the Dimensions panel, so that might be a good place to look? To clarify, it probably only makes sense for the Layout panel to be added to container blocks in this context, IE the comment query loop and the comment template. But obviously we can only do that once the feature has been added – my apologies, I thought it already had been. |
The post comment block is in the theme category, but the inner blocks are in the design category, is that correct or should they all be in the theme category? |
Personally I think the inner blocks are more aligned with the other blocks in the theme category. But without wanting to open a can of worms, could there be an argument for a dedicated "Comments" section? There are quite a few blocks here... |
As we work through these, I'd like to drop all the "Post" prefixes and just settle on "Comment Content", "Comment Author", etc. |
Perhaps this is obvious but I'd like to clarify: If a user submits a new comment, we would still require a full page reload in order to show that new comment, correct? As opposed to creating a sort of "optimistic update" and showing the just-submitted comment without a reload. |
Do you mean like creating a comment in the front-end and show the results in the editor? |
That's correct Michal.
I think he means rendering the comment in the browser after submission. |
yup, that's what I meant. Thanks Luis! |
There has been some progress during the last weeks and I'd like to make a quick summary update. These are the issues we have worked on, and the status of each of them:
Feel free to add anything that I'm missing, and you can find more information in each Pull Request |
A new update on the Post Comments blocks. This was the progress made during the last couple of weeks:
For now, we will keep working on the aspects left in the Comment Query Loop block and start working on the blocks related to the Comments pagination. Feel free to add anything missing |
Description
The idea of this issue is to end up with a Comments Loop Block (name may change) that loops over the comments of a given post. This would be similar to the Query Loop used for posts. Users should be able to define and change the layout of the post comments directly from the Gutenberg editor, and both the editor and the frontend should match.
This is how the different comment blocks should look like:
https://excalidraw.com/#json=6537760064143360,EgfZIljXt2SI2DTSFebHQQ
Existing Solution / Workaround
Right now, there are two similar blocks:
comments.php
file of the PHP theme in the frontend and a loop of paragraphs in the editor. This way, the editor and the frontend are different and users aren't able to change the layout unless they change the PHP code.Tasks
These are the steps we should follow to finish the tracking issue:
Please note that I'll be adding the relevant issues once they are created.
Out of scope
There are some functionalities that could be nice to work on but that won't be covered in this tracking issue, although they may be addressed later in the future:
Questions
Of course, any feedback apart from these questions is more than welcome🙂
Previous work
There has been already some work done related to the Comments Block that was tracked in this issue → #24101
The text was updated successfully, but these errors were encountered: