Use longer option names in install_db() to avoid stalling CIs
#255
Conversation
Since some platforms (such as Travis CI) use empty passwords for the database user, passing an empty string for `$DB_PASS` can result in a TTY prompt, e.g.: ``` $ DB_USER=someuser DB_PASS="" mysql -u "$DB_USER" -p"$DB_PASS" -e 'show databases;' Enter password: ``` This commit rewrites the call to use the longer option names (`--user`, `--password`, and `--execute`) to prevent empty passwords from being interpreted as "please ask me to provide my password in an interactive prompt."
stevegrunwell
added a commit
to assertwell/wp-core-test-framework
that referenced
this pull request
Mar 26, 2020
stevegrunwell
added a commit
to assertwell/wp-core-test-framework
that referenced
this pull request
Mar 26, 2020
* Manually apply the patch from wp-cli/scaffold-command#255 ahead of official merger. https://github.com/assertwell/wp-core-test-framework/releases/tag/v0.1.1
schlessera
changed the title
schlessera
changed the title
install_db() to avoid stalling CIs
schlessera
merged commit e52f050
into
wp-cli:master
1 of 2 checks passed
1 of 2 checks passed
DEP
All dependencies are resolved
|
Thanks for the PR, @stevegrunwell ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Since some platforms (such as Travis CI) use empty passwords for the database user, passing an empty string for
$DB_PASScan result in a TTY prompt, e.g.:In a CI environment, this can cause the entire pipeline to hang until cancelled.
This PR rewrites the call to use the longer option names (
--user,--password, and--execute) to prevent empty passwords from being interpreted as "please ask me to provide my password in an interactive prompt."