Update expression for dependencies of PHPUnit #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlessera
requested changes
Aug 26, 2020
plugin-unit-tests.md
Outdated
| * [The latest version of WordPress supports PHPUnit 7.x](https://make.wordpress.org/core/handbook/testing/automated-testing/phpunit/#setup) | ||
| * The legacy version of WordPress supported PHPUnit 5.x only when running PHP 7 | ||
| * The legacy version of WordPress required PHPUnit 4.8 when running PHP 5 |
There was a problem hiding this comment.
It would actually be helpful if the precise WordPress versions were mentioned, like "WordPress 5.5+ (is this correct) supports PHPUnit 7.x".
There was a problem hiding this comment.
I found Supported Version Chart:
PHPUnit Compatibility and WordPress Versions – Make WordPress Core
Is it better to replace all with link to this page?
There was a problem hiding this comment.
Yes, that way we don;t have to maintain the exact requirements in here.
There was a problem hiding this comment.
Updated.
Replace explanation of support PHPUnit version with link to Supported Version Chart in WordPress core handbook.
schlessera
approved these changes
May 14, 2021
|
Thanks for the PR, @yukihiko-shinoda ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The latest version of WordPress supports PHPUnit 7.x.
@see https://core.trac.wordpress.org/ticket/50482#comment:8
@see https://make.wordpress.org/core/handbook/testing/automated-testing/phpunit/#setup
I checked that my maintaining CI for WordPress plugin works well with WordPress latest and PHPUnit 7.x.
Build #27 - yukihiko-shinoda/staticpress2019 - Travis CI
The text was updated successfully, but these errors were encountered: