Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emulate WordPress SQL mode compat hack #169

Merged
merged 2 commits into from Apr 17, 2020
Merged

Emulate WordPress SQL mode compat hack #169

merged 2 commits into from Apr 17, 2020

Conversation

@schlessera
Copy link
Member

@schlessera schlessera commented Apr 17, 2020

This prepends a SELECT statement to each query that goes directly through the mysql binary (instead of the WPDB abstraction) to set the SQL mode to a state compatible with WordPress Core behavior.

Fixes #168
@schlessera schlessera marked this pull request as ready for review Apr 17, 2020
@schlessera schlessera requested a review from as a code owner Apr 17, 2020
@schlessera schlessera added this to the 2.0.7 milestone Apr 17, 2020
@schlessera schlessera merged commit 9bbc2cf into master Apr 17, 2020
1 check passed
Loading
@schlessera schlessera deleted the 168-adapt-sql-mode branch Apr 17, 2020
@schlessera schlessera mentioned this pull request Apr 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wp-cli/committers committers

Assignees
No one assigned
Labels
bug command:db-query
Projects
None yet
Milestone
2.0.7
Linked issues

Successfully merging this pull request may close these issues.

Adapt SQL mode to account for WordPress incompatibilities
1 participant
@schlessera