Skip to content

/ gutenberg

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation mode: strange arrow key behaviour in nested blocks #30155

Open
ellatrix opened this issue Mar 23, 2021 · 4 comments
Open

Navigation mode: strange arrow key behaviour in nested blocks #30155

ellatrix opened this issue Mar 23, 2021 · 4 comments
Labels
Accessibility (a11y) [Feature] Writing Flow [Type] Bug

Comments

@ellatrix
Copy link
Member

@ellatrix ellatrix commented Mar 23, 2021

Create a column block with a paragraph in one of the columns and leave the paragraph selected. Press Esc to enter navigation mode.

  • Arrow up and down don't do anything.
  • Arrow right doesn't do anything.
  • Arrow left selects the column, which seems reasonable.

Now that the column is selected:

  • Arrow down selects the next column... This is strange. I expect something downwards to be selected.
  • Arrow right selects the paragraph inside the column. I expect the column to the right to be selected.
  • Arrow up doesn't do anything.
  • Arrow left selects the columns block, which again seems reasonable.

I would expect navigation mode to work more similarly like edit mode. Maybe we should reuse writing flow to also handle arrow navigation for navigation mode?
@ellatrix
Copy link
Member Author

@ellatrix ellatrix commented Mar 23, 2021

Cc @youknowriad since you know most about navigation mode. :)
@youknowriad
Copy link
Contributor

@youknowriad youknowriad commented Mar 23, 2021

I think the nested behavior was implemented as a v2 by @tellthemachines if I'm not wrong. For me at least, down and right should work the same and up and left as well because we shouldn't assume container orientation. and I expect like you to first go through the nested blocks before going to the next one.
@youknowriad
Copy link
Contributor

@youknowriad youknowriad commented Mar 23, 2021

Potentially we could leverage "orientation" config to be more precise but not sure if worth the complexity.
@ellatrix
Copy link
Member Author

@ellatrix ellatrix commented Mar 23, 2021

We don't need to look at container orientation if we just reuse the existing logic in writing flow. Instead of moving focus only the block selection would move.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accessibility (a11y) [Feature] Writing Flow [Type] Bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@youknowriad @ellatrix