Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalized reference to parsed block properites #28436

Open
wants to merge 1 commit into
base: master
from

Conversation

@krfreder
Copy link

@krfreder krfreder commented Jan 22, 2021

Fixed #5449

Description

[x] getBlockContent, getCommentDelimitedContent

  • Recommendations:
    • Rename getBlockContent to getBlockInnerHTML
    • Rename getCommentDelimitedContent to getCommentDelimitedBlockInnerHTML

[ ] serializeAttributes

  • Recommendation:
    - Rename attrs argument to attributes
    • Add a JSDoc block for the function
  • Section was already completed

[x] Post grammar

  • Recommendations:
    • Rename attrs to attributes
    • Rename blockName to name

How has this been tested?

npm test
npm run test-unit
ESLint

Screenshots

Types of changes

Feature: Block API
Features: Parsing

Checklist:

  • [x ] My code is tested.
  • [x ] My code follows the WordPress code style.
  • [x ] My code follows the accessibility standards.
  • [x ] My code has proper inline documentation.
  • [x ] I've included developer documentation if appropriate.
  • [x ] I've updated all React Native files affected by any refactorings/renamings in this PR.
@krfreder krfreder requested a review from dmsnell as a code owner Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant