Size Change: +486 B (0%)

Total Size: 1.07 MB

_{compressed-size-action}

Hi, Nik

I just wanted to note that we want this component to be backward compatible with unitless values. See #33679.

We have unit tests in place, so the regression should be easy to catch.

Thanks for starting work on this one. It's a big one, it's a difficult one, and it's so nice to get something on the blank canvas. Here's a GIF of what I saw in a quick testing:

I'll need to come back to this one with deeper thoughts, but a few quick superficial observations:

• Would it make sense to make progress on the generic input-field component work? The 40px input fields from #34574 and #27331 might benefit the work here, just to have in place.
• The goal of the toolspanel is, in part, to retire the many Reset buttons strewn across the inspector. I wonder if we should tie this PR to #33744 by @aaronrobertshaw?
• The "Custom" option in the dropdown didn't seem to work for me, but hitting the settings icon did.

This is just one small ingredient of a large effort, nice work, and I think many of the pieces will start falling into place once we get this one down.

Thanks for the first tests @jasmussen and great remarks!

Would it make sense to make progress on the generic input-field component work?
The goal of the toolspanel is, in part, to retire the many Reset buttons strewn across the inspector. I wonder if we should tie this PR to Typography: Switch to ToolsPanel for display UI #33744 by @aaronrobertshaw?

Yes, it makes sense to fix/augment existing components that are going to be used. I made the draft to pause a bit and check some related PRs like the ToolsPanel that handle the reset, etc..

The "Custom" option in the dropdown didn't seem to work for me, but hitting the settings icon did.

I know about that and haven't decided yet how to handle the options (default + custom) as it will also be coupled with ToggleGroupControl.

The goal of the toolspanel is, in part, to retire the many Reset buttons strewn across the inspector. I wonder if we should tie this PR to Typography: Switch to ToolsPanel for display UI #33744 by @aaronrobertshaw?

Thanks for the ping. It's great to see progress on the new typography components. 馃憤

I did have some tweaks to the current FontSizePicker included in #33744 to allow the omission of the reset button and fix up spacing when used within the ToolsPanel. Those tweaks have just been removed from that PR although I planned to create a separate PR with them tomorrow.

If you'd prefer for me to put those changes on ice until this PR evolves, let me know. Even as it is now, the version of FontSizePicker in this PR would fit a little nicer within the ToolsPanel than the version on trunk.

Other than the reset button, the only other tweak for the ToolsPanel would be removing the bottom margin so that the panel's grid can handle the spacing.

Applying these changes alongside #33744 appears to work well and I'd expect it to evolve without many conflicts.

I did encounter one small issue while testing which was in a couple of themes the select options included NaN in them. I believe this was due to the theme's font size presets using CSS vars for the size property. The Q theme is one example.

Would it make sense to make progress on the generic input-field component work? The 40px input fields from The Global Styles Interface #34574 and Sidebar Controls & Component System #27331 might benefit the work here, just to have in place.

Hey @jasmussen , that definitely makes sense (although in a separate issue/PR). We should be adding any changes that are necessary to improve the typography panel in tracking issue #34345, so that we can take it from there and coordinate around these tasks.

With respect to what @aaronrobertshaw said, that sounds like a good plan to me!

I did encounter one small issue while testing which was in a couple of themes the select options included NaN in them. I believe this was due to the theme's font size presets using CSS vars for the size property.

I'll look into this, thanks!

Regarding the reset I'm going to try to maybe have a first iteration with the reset button and the current custom size input with the units (no slider). We'll see how this goes and has to do with the other tools panel PRs. Remove the reset button will be easy 馃槃 .