Skip to content

/ gutenberg Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed: Remove meetup-com from variations #35146

Merged
merged 1 commit into from Sep 28, 2021
Merged

Embed: Remove meetup-com from variations #35146

merged 1 commit into from Sep 28, 2021
+0 −8

Conversation

@MuhammadFaizanHaidar
Copy link
Contributor

@MuhammadFaizanHaidar MuhammadFaizanHaidar commented Sep 27, 2021 •
edited

fixes: #35085

Description

Removed meetup-com block from variation.js
https://github.com/MuhammadFaizanHaidar/gutenberg/blob/remove-meetup.com-var/packages/block-library/src/embed/variations.js LN:207

How has this been tested?

Screenshots

meetup-com

Types of changes

It removes the deprecated oembed for meetup.com

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
@MuhammadFaizanHaidar
removed meetup-com block from variation.js
0b97cf1
@github-actions
Copy link

@github-actions github-actions bot commented Sep 27, 2021

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @MuhammadFaizanHaidar! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@Mamaduka Mamaduka requested a review from bph Sep 28, 2021
aristath
aristath approved these changes Sep 28, 2021
View changes
Copy link
Member

@aristath aristath left a comment

Simple change, looks good to me 👍

@Mamaduka Mamaduka changed the title removed meetup-com block from variation.js Embed: Remove meetup-com from variations Sep 28, 2021
@Mamaduka Mamaduka merged commit 7bf19a5 into WordPress:trunk Sep 28, 2021
20 checks passed
@github-actions github-actions bot added this to the Gutenberg 11.7 milestone Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aristath aristath

@ajitbohra ajitbohra

@bph bph

Assignees
No one assigned
Labels
[Block] Embed First-time Contributor [Type] Bug
Projects
None yet
Milestone
Gutenberg 11.7
Linked issues

Successfully merging this pull request may close these issues.

Remove Meetup.com variation from the embed block
3 participants
@MuhammadFaizanHaidar @aristath @Mamaduka