Skip to content

/ gutenberg Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace tinycolor2 with colord on getMostReadableColor util. Add unit test. #34625

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Replace tinycolor2 with colord on getMostReadableColor util. Add unit test. #34625

wants to merge 1 commit into from
+59 −5

Conversation

@jorgefilipecosta
Copy link
Member

@jorgefilipecosta jorgefilipecosta commented Sep 7, 2021

Part of #34286.
This PR replaces the tinycolor2 library with colord on the getMostReadableColor block editor util.
We are also adding some unit tests for this util given that the function did not had any tests.

How has this been tested?

I verified the unit tests are passing.
@jorgefilipecosta
Replace tinycolor2 with colord on block editor getMostReadableColor u…
bde7568 
…til. Add unit test.
@jorgefilipecosta jorgefilipecosta requested a review from ellatrix as a code owner Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellatrix ellatrix

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Automated Testing [Type] Code Quality
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@jorgefilipecosta