Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizing the no-results behavior of the query block #27302

Open
aristath opened this issue Nov 26, 2020 · 2 comments
Open

Allow customizing the no-results behavior of the query block #27302

aristath opened this issue Nov 26, 2020 · 2 comments

Comments

@aristath
Copy link
Member

@aristath aristath commented Nov 26, 2020

Came up in #25790
We should allow users to customize the behavior of the query block when no results are found.

@annezazu
Copy link
Contributor

@annezazu annezazu commented Mar 3, 2021

Pulling from the FSE Outreach Program's latest call for testing, wanted to mention this piece of feedback as this issue is considered:

when a Query block has been inserted but is empty (i.e. no post content), markup for the block is still output to the front-end: <ul class=”wp-block-query-loop”></ul>. This will likely also create additional white-space on the front-end, due to a top margin being applied to the <ul> tag.

@ntsekouras
Copy link
Contributor

@ntsekouras ntsekouras commented Mar 3, 2021

when a Query block has been inserted but is empty (i.e. no post content), markup for the block is still output to the front-end: <ul class=”wp-block-query-loop”></ul>. This will likely also create additional white-space on the front-end, due to a top margin being applied to the <ul> tag.

Thanks for reporting this @annezazu! I created a small PR to fix this: #29521

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Full site editing
  
Awaiting triage
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants