Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editing Infrastructure and UI: Part 3 #27814

Open
6 of 16 tasks
youknowriad opened this issue Dec 18, 2020 · 10 comments
Open
6 of 16 tasks

Site Editing Infrastructure and UI: Part 3 #27814

youknowriad opened this issue Dec 18, 2020 · 10 comments

Comments

@youknowriad
Copy link
Contributor

@youknowriad youknowriad commented Dec 18, 2020

In #26355 we've introduced an initial version for the template editor mode in the post editor. This highlighted a few issues in the design/flows of that feature. The current issue is an overview tracking the progress for all oft these follow-ups:

Blank Canvas Template

  • Allow creating custom block templates in classic themes #30438
  • Better distinguish between the content editor and the template editor. The users should be able to quickly tell which mode they are currently working with. #27849

Interface

  • Allow deleting new custom block templates, and reverting customized block templates in the template editor #31076
  • View the template while editing the post #27847
  • Design UX patterns for blocks based on context (content editing vs template editing) that enable users to flow between content editing and template editing directly on the canvas. #27848
  • Explore a pattern for template part editing that is consistent in both content and template editing contexts #27852
  • Allow selecting custom page templates. #27778
  • Find a visual way to list the available page templates (actually preview the templates and maybe show them in a starting modal). #27850, #31591
  • Give the user the possibility to save the changes to a template specific to the current post or a custom template that can be used in other posts too. #27851
  • Add a welcome guide for the template mode. #29031
  • Colorise template parts and reusable blocks in the UI #32163
  • Mosaic View of Theme Templates. #20477
  • Bug: Template part click-through #35079

Infrastructure

  • Allow using post meta values as "sources" for some of the blocks used in the template.
  • Allow themes to opt-in/out of the "Create new template" flow.
  • Support dynamic values in block-based templates. #20966 #25316
@skorasaurus
Copy link
Member

@skorasaurus skorasaurus commented Dec 29, 2020

One more suggestion to add: While editing a template within the post editor, I went to the code editor mode, and the code editor mode returned the content of the post, not the template's content (what I expected); this is a result of #22528

@youknowriad
Copy link
Contributor Author

@youknowriad youknowriad commented Apr 8, 2021

#30438 is now merged so classic themes can use blocks to build custom templates for pages and all CPTs that support Page templates now.

@priethor
Copy link
Contributor

@priethor priethor commented Apr 20, 2021

Added Allow themes to opt-in/out of the "Create new template" flow to the list.

@youknowriad
Copy link
Contributor Author

@youknowriad youknowriad commented Apr 21, 2021

Added Allow themes to opt-in/out of the "Create new template" flow to the list.

That's already possible with the block-templates support flag. you can do remove_theme_support( 'block-templates' );

@carolinan
Copy link
Contributor

@carolinan carolinan commented Apr 22, 2021

Short term, are the template and template part menus under Appearance going to be in 5.8?

If not:

  • How can user created templates be deleted?
  • Editing templates is possible, but you would first have to find a page or post that uses that template, or create a new page or post just to access that template.
  • How can users edit templates that are not post or pages, such as search, archive, and 404?

If kept:
The editing views in the appearance>edit templates and block editor>edit template are not the same.
What is the intention with these separate views?

@youknowriad
Copy link
Contributor Author

@youknowriad youknowriad commented Apr 22, 2021

I think these screens are not meant to be shipped at all. So yeah if the template editor makes it to 5.8, we need at least a "delete" template somewhere in the template mode or the template panel.

@jameskoster
Copy link
Contributor

@jameskoster jameskoster commented Apr 22, 2021

How can users edit templates that are not post or pages, such as search, archive, and 404?

Assuming dedicated template management (IE Appearance > Templates) doesn't ship in 5.8, it won't be possible to create these templates in the UI. So I think it's fair to assume there will not be an expectation of edit-ability either.

we need at least a "delete" template somewhere in the template mode or the template panel

There is a revert affordance for customised block theme templates in the site editor. We can use that same design for deletion in the template editor. I'll make an issue.

@carolinan
Copy link
Contributor

@carolinan carolinan commented Apr 22, 2021

it won't be possible to create these templates in the UI
You meant in the appearance > templates UI? Or not create templates at all via any sort of UI 😕

@jameskoster
Copy link
Contributor

@jameskoster jameskoster commented Apr 22, 2021

Not create the templates you mentioned specifically: search, archive, 404, etc.

@priethor
Copy link
Contributor

@priethor priethor commented Apr 22, 2021

we need at least a "delete" template somewhere in the template mode or the template panel.

Added this to the list based on the recently created #31076

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants