Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template editor and front-end alignment styles do not match #32069

Closed
jffng opened this issue May 20, 2021 · 1 comment · Fixed by #32425
Closed

Template editor and front-end alignment styles do not match #32069

jffng opened this issue May 20, 2021 · 1 comment · Fixed by #32425
Assignees
@youknowriad
Labels
[Feature] Full Site Editing [Feature] Template Editing Mode Needs Dev [Status] In Progress [Type] Bug
Projects
WordPress 5.8 Must Haves

Comments

@jffng
Copy link
Contributor

@jffng jffng commented May 20, 2021 •
edited

Description

In template editing mode, the template editor and front-end alignment do not match by default.

Step-by-step reproduction instructions

  • Activate tt1-blocks (a theme that opts into the new layout system by providing default content sizes )
  • Go to the post editor and create a new template
  • Add some blocks
  • Preview or publish the template

@annezazu made a recording of this also.

Screenshots or screen recording (optional)

Editor View
Screen Shot 2021-05-20 at 5 08 04 PM Screen Shot 2021-05-20 at 5 07 44 PM
@annezazu annezazu added this to 📥 To do in WordPress 5.8 Must Haves via automation May 20, 2021
@youknowriad
Copy link
Contributor

@youknowriad youknowriad commented May 26, 2021

The Post Editor automatically applies the "layout" config (sizes), it seems that config shouldn't apply to the template mode as well. Template mode should work more like the site editor (no default layout applied)

@youknowriad youknowriad mentioned this issue Jun 3, 2021
Merged
@youknowriad youknowriad moved this from 📥 To do to 🏗️ In progress in WordPress 5.8 Must Haves Jun 3, 2021
WordPress 5.8 Must Haves automation moved this from 🏗️ In progress to ✅ Done Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youknowriad youknowriad

Labels
[Feature] Full Site Editing [Feature] Template Editing Mode Needs Dev [Status] In Progress [Type] Bug
Projects
No open projects
WordPress 5.8 Must Haves
  
✅ Done
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Fix the layout definition in the template mode
3 participants
@youknowriad @jffng @annezazu