This repository has been archived by the owner on Aug 4, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes WordPress/openverse#1712 by @obulat
Description
This PR creates a
DbColumn
class that defines a database column, and describes its behavior on conflict, when updating data. A list of columns for different media types and loading and main database (openledger, also referred to as upstream) makes it easy to create SQL query strings.The PR moves the mediatype-specific columns to the end of the loading table, so that the column lists for different media types can be created simply by concatenating a list of common columns with a list of media type - specific columns. This caused a lot of tests to break.
This PR also removes legacy workflows for cleaning up DB tables, used before the ImageStore was used to clean up media data. They are no longer necessary since all the back up data we have has already been cleaned, and the data we collect from the APIs will be cleaned up through ImageStore.
Technical details
Tests
Screenshots
Checklist
Update index.md
).main
ormaster
).Developer Certificate of Origin
Developer Certificate of Origin