Skip to content

/ playwright Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: alias Fetch as ApiRequest #9330

Merged
merged 1 commit into from Oct 6, 2021
Merged

api: alias Fetch as ApiRequest #9330

merged 1 commit into from Oct 6, 2021

Conversation

@pavelfeldman
Copy link
Member

@pavelfeldman pavelfeldman commented Oct 6, 2021

No description provided.

yury-s
yury-s approved these changes Oct 6, 2021
View changes
docs/src/api/class-playwright.md
obtained via [`method: BrowserContext.storageState`] or [`method: FetchRequest.storageState`]. Either a path to the
file with saved storage, or the value returned by one of [`method: BrowserContext.storageState`] or
[`method: FetchRequest.storageState`] methods.
- type: <[ApiRequest]>
Copy link
Member

@yury-s yury-s Oct 6, 2021

Let's add some description for the property.

docs/src/api/class-apirequest.md

Exposes API that can be used for Web API testing.

## async method: ApiRequest.newContext
Copy link
Member

@yury-s yury-s Oct 6, 2021

how about getting rid of ApiRequest and replacing it with playwright.newApiSession/Context ?

Copy link
Member Author

@pavelfeldman pavelfeldman Oct 6, 2021

I don't want to introduce a function on the top level namespace.

@pavelfeldman
api: alias Fetch as ApiRequest
e816f76
@pavelfeldman pavelfeldman merged commit e8fdbbf into microsoft:master Oct 6, 2021
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yury-s yury-s

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@pavelfeldman @yury-s