Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

Use just commands in CI workflow #218

Conversation

AetherUnbound
Copy link
Contributor

Fixes

Fixes #216 by @AetherUnbound

Description

This PR uses the setup-just GitHub Action to allow us to use just in the CI workflows rather than explicit commands.

I also added a just lint recipe for running pre-commit on its own.

Testing Instructions

See if the build passes 馃榿 Alternatively, run just lint locally with your virtual environment activated.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@AetherUnbound AetherUnbound added 馃 aspect: dx Concerns developers' experience with the codebase 馃О goal: internal improvement Improvement that benefits maintainers, not users labels Oct 5, 2021
@dhruvkb dhruvkb added this to Needs review in Openverse PRs Oct 5, 2021
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes the CI process much simpler to understand. LGTM!

Openverse PRs automation moved this from Needs review to Reviewer approved Oct 5, 2021
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AetherUnbound AetherUnbound merged commit 0be7797 into improvement/development-docker-compose#212 Oct 5, 2021
Openverse PRs automation moved this from Reviewer approved to Merged! Oct 5, 2021
@AetherUnbound AetherUnbound deleted the feature/github-workflow-just#216 branch October 5, 2021 15:23
AetherUnbound added a commit that referenced this pull request Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
馃 aspect: dx Concerns developers' experience with the codebase 馃О goal: internal improvement Improvement that benefits maintainers, not users
Projects
No open projects
Openverse PRs
  
Merged!
Development

Successfully merging this pull request may close these issues.

None yet

3 participants