pybind11: migrate to [email protected] #86775
Conversation
BrewTestBot
added
the
python
|
Looks like dependent formula need to be moved too (which makes sense). It’s just a few headers and config files. |
|
Honestly, multiple installs like six would probably be fine. |
Sounds fine. And simpler. |
BrewTestBot
removed
the
python
henryiii
force-pushed
the
[email protected]
branch
2 times, most recently
from
74a876f
to
a9fdd16
Compare
Formula/pybind11.rb
Outdated
|
|
||
| # Also pybind11-config | ||
| bin.install Dir[libexec/"bin/*"] | ||
| bin.install Dir[libexec/"bin/pybind11-config*"] |
There was a problem hiding this comment.
I"m making pybind11-config-3.10 and such, and then including all of them + the latest one unversioned (this is the only thing that was colliding when installing this per-python version). I don't have to include the versioned ones, and we don't require these pythons - I could require python 3.10 since pybind11-config requires it. Thinking about it, adding versioned ones as outputs is likely not a good idea.
There was a problem hiding this comment.
I have dropped the two test lines and changed this to bin.install Dir[libexec/"bin/pybind11-config"].
There was a problem hiding this comment.
Note requiring [email protected] will trigger the mixed-version-dependency audit.
henryiii
force-pushed
the
[email protected]
branch
from
32024b1
to
50c3457
Compare
|
Still left 3.10 as the source for Also haven't extracted this into a method, missed that. Can do on next edit. |
Co-authored-by: Carlo Cabrera <[email protected]> Signed-off-by: Carlo Cabrera <[email protected]>
carlocab
force-pushed
the
[email protected]
branch
from
50c3457
to
b00557b
Compare
|
🤖 A scheduled task has triggered a merge. |
pybind11: migrate to [email protected]