#31589 closed theme (live)
THEME: SEO WP – 1.0.5
Reported by: |
|
Owned by: |
|
---|---|---|---|
Priority: | previously reviewed | Keywords: | theme-seo-wp |
Cc: | wordpressparena@… |
Description
SEO WP - 1.0.1
SEO WP – Blog WordPress Theme with Material Design
Theme URL - https://wparena.com/seo-wp-blog-wordpress-theme
Author URL - https://wparena.com/
SVN - https://themes.svn.wordpress.org/seo-wp/1.0.1
ZIP - https://wordpress.org/themes/download/seo-wp.1.0.1.zip?nostats=1
Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=seo-wp/1.0.0&new_path=seo-wp/1.0.1
History:
Ticket | Summary | Status | Resolution | Owner |
---|---|---|---|---|
#28974 | THEME: SEO WP – 1.0.0 | closed | closed-newer-version-uploaded | rabmalin |
#31589 | THEME: SEO WP – 1.0.5 | closed | live | rabmalin |
#32863 | THEME: SEO WP – 1.0.6 | closed | live | themetracbot |
#33504 | THEME: SEO WP – 1.0.7 | closed | live | themetracbot |
#38332 | THEME: SEO WP – 2.0 | closed | live | themetracbot |
#40239 | THEME: SEO WP – 2.1 | closed | live | themetracbot |
Change History (19)
#1
@grapplerulrich
11 months ago
- Owner set to rabmalin
- Status changed from new to reviewing
#3
@themetracbot
11 months ago
- Summary changed from THEME: SEO WP – 1.0.1 to THEME: SEO WP – 1.0.2
SEO WP - 1.0.2
SEO WP – Blog WordPress Theme with Material Design
Theme URL - https://wparena.com/seo-wp-blog-wordpress-theme
Author URL - https://wparena.com/
SVN - https://themes.svn.wordpress.org/seo-wp/1.0.2
ZIP - https://wordpress.org/themes/download/seo-wp.1.0.2.zip?nostats=1
Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=seo-wp/1.0.1&new_path=seo-wp/1.0.2
History:
Ticket | Summary | Status | Resolution | Owner |
---|---|---|---|---|
#28974 | THEME: SEO WP – 1.0.0 | closed | closed-newer-version-uploaded | rabmalin |
#31589 | THEME: SEO WP – 1.0.5 | closed | live | rabmalin |
#32863 | THEME: SEO WP – 1.0.6 | closed | live | themetracbot |
#33504 | THEME: SEO WP – 1.0.7 | closed | live | themetracbot |
#38332 | THEME: SEO WP – 2.0 | closed | live | themetracbot |
#40239 | THEME: SEO WP – 2.1 | closed | live | themetracbot |
#4
@rabmalin
11 months ago
Only few issues remaining
Issues
- REQUIRED: Please mention license information and full image URL of images used in the screenshot.
- REQUIRED: You need to keep unminified version of materialize.min.js also.
- REQUIRED: Roboto font is not compatible with GPLv2. Either you need to change font or if you want to use Roboto then you would have to change your theme license from GPLv2 to GPLv3.
- REQUIRED: When I go to https://wparena.com/seo-wp-blog-wordpress-theme it is redirected to https://wparena.com/. Can you please check it?
- REQUIRED: Please remove this code. You need not implement back compatibility for more than 3 versions.
if ( version_compare( $GLOBALS['wp_version'], '4.1', '<' ) ) : /** * Filters wp_title to print a neat <title> tag based on what is being viewed. * * @param string $title Default title text for current view. * @param string $sep Optional separator. * * @return string The filtered title. */ function seo_wp_wp_title( $title, $sep ) { if ( is_feed() ) { return $title; } global $page, $paged; // Add the blog name. $title .= get_bloginfo( 'name', 'display' ); // Add the blog description for the home/front page. $site_description = get_bloginfo( 'description', 'display' ); if ( $site_description && ( is_home() || is_front_page() ) ) { $title .= " $sep $site_description"; } // Add a page number if necessary. if ( ( $paged >= 2 || $page >= 2 ) && ! is_404() ) { $title .= " $sep " . sprintf( esc_html__( 'Page %s', 'seo-wp' ), max( $paged, $page ) ); } return $title; } add_filter( 'wp_title', 'seo_wp_wp_title', 10, 2 ); endif;
#5
@themetracbot
11 months ago
- Summary changed from THEME: SEO WP – 1.0.2 to THEME: SEO WP – 1.0.3
SEO WP - 1.0.3
SEO WP – Blog WordPress Theme with Material Design
Theme URL -
Author URL - https://wparena.com/
SVN - https://themes.svn.wordpress.org/seo-wp/1.0.3
ZIP - https://wordpress.org/themes/download/seo-wp.1.0.3.zip?nostats=1
Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=seo-wp/1.0.2&new_path=seo-wp/1.0.3
History:
Ticket | Summary | Status | Resolution | Owner |
---|---|---|---|---|
#28974 | THEME: SEO WP – 1.0.0 | closed | closed-newer-version-uploaded | rabmalin |
#31589 | THEME: SEO WP – 1.0.5 | closed | live | rabmalin |
#32863 | THEME: SEO WP – 1.0.6 | closed | live | themetracbot |
#33504 | THEME: SEO WP – 1.0.7 | closed | live | themetracbot |
#38332 | THEME: SEO WP – 2.0 | closed | live | themetracbot |
#40239 | THEME: SEO WP – 2.1 | closed | live | themetracbot |
#6
@rabmalin
11 months ago
- Status changed from reviewing to approved
Marking as approved. Please be patient. After approval of theme, admin will once again review your theme. Only after admin approval your theme will be live. You can check this link to find out your theme position in the queue. https://themes.trac.wordpress.org/report/24
#7
@chipbennett
10 months ago
- Status changed from approved to reopened
Required
- Use the core custom logo implementation. Especially since logo is the only available Theme option, this should be ported over to the core feature implementation prior to approval.
- Remove stylesheet minification (Plugin territory)
- Include comments template in index.php
Questions
The readme file indicates a reference to the solon Theme. What is the connection to that Theme? If this Theme was derived from that one, you need to attribute it.
#8
@chipbennett
10 months ago
- Status changed from reopened to reviewing
#9
@rabmalin
10 months ago
Hello @WordPressArena
Pinging you just to confirm that you got notification about the ticket. Please fix issues mentioned above and reupload your theme. Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.
Thanks
#10
@WordPressArena
10 months ago
@chipbennett,
How about including comments template in index.php? This thing is new for me, I don't understand why it's required. Please advise!
And the theme has no connections with solon theme.
#11
@chipbennett
10 months ago
Don't worry about comments template in index.php. It is an edge case/minor thing.
Re: solon Theme: https://themes.trac.wordpress.org/browser/seo-wp/1.0.3/readme.txt?rev=59623#L40
#12
@themetracbot
10 months ago
- Summary changed from THEME: SEO WP – 1.0.3 to THEME: SEO WP – 1.0.4
SEO WP - 1.0.4
SEO WP – Blog WordPress Theme with Material Design
Theme URL - https://wparena.com/seo-wp-wordpress-theme/
Author URL - https://wparena.com/
SVN - https://themes.svn.wordpress.org/seo-wp/1.0.4
ZIP - https://wordpress.org/themes/download/seo-wp.1.0.4.zip?nostats=1
Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=seo-wp/1.0.3&new_path=seo-wp/1.0.4
History:
Ticket | Summary | Status | Resolution | Owner |
---|---|---|---|---|
#28974 | THEME: SEO WP – 1.0.0 | closed | closed-newer-version-uploaded | rabmalin |
#31589 | THEME: SEO WP – 1.0.5 | closed | live | rabmalin |
#32863 | THEME: SEO WP – 1.0.6 | closed | live | themetracbot |
#33504 | THEME: SEO WP – 1.0.7 | closed | live | themetracbot |
#38332 | THEME: SEO WP – 2.0 | closed | live | themetracbot |
#40239 | THEME: SEO WP – 2.1 | closed | live | themetracbot |
#13
@rabmalin
10 months ago
Hello
Please fix issues and reupload your theme.
Issues
- REQUIRED: Implementation of Custom Logo is not working. Please check again. See this link: https://make.wordpress.org/core/2016/03/10/custom-logo/
- REQUIRED: Remove this function if not used seo_wp_customize_register_logo(). customizer.php.
- REQUIRED: You added new widget but its not working.
- REQUIRED: seo_wp_excerpt - To show excerpt you have used custom function. Please use this instead and remove seo_wp_excerpt() function.
- REQUIRED: WP already provides the_posts_pagination() for pagination. Use this function instead and remove seo_wp_pagination() function.
#14
@themetracbot
10 months ago
- Summary changed from THEME: SEO WP – 1.0.4 to THEME: SEO WP – 1.0.5
SEO WP - 1.0.5
SEO WP – Blog WordPress Theme with Material Design
Theme URL - https://wparena.com/seo-wp-wordpress-theme/
Author URL - https://wparena.com/
SVN - https://themes.svn.wordpress.org/seo-wp/1.0.5
ZIP - https://wordpress.org/themes/download/seo-wp.1.0.5.zip?nostats=1
Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=seo-wp/1.0.4&new_path=seo-wp/1.0.5
History:
Ticket | Summary | Status | Resolution | Owner |
---|---|---|---|---|
#28974 | THEME: SEO WP – 1.0.0 | closed | closed-newer-version-uploaded | rabmalin |
#31589 | THEME: SEO WP – 1.0.5 | closed | live | rabmalin |
#32863 | THEME: SEO WP – 1.0.6 | closed | live | themetracbot |
#33504 | THEME: SEO WP – 1.0.7 | closed | live | themetracbot |
#38332 | THEME: SEO WP – 2.0 | closed | live | themetracbot |
#40239 | THEME: SEO WP – 2.1 | closed | live | themetracbot |
#15
@rabmalin
10 months ago
- Status changed from reviewing to approved
Thanks for fixing all issues so quick. Now @chipbennett will continue admin review.
#16
@chipbennett
10 months ago
- Resolution set to live
- Status changed from approved to closed
Based on a cursory diff review, looks good. Marking this version as "Live". Congratulations, and thank you for contributing to WordPress!
#17
follow-up:
↓ 19
@WordPressArena
10 months ago
@chipbennett
How to commit files to svn: https://themes.svn.wordpress.org/seo-wp/
#18
@rabmalin
10 months ago
@WordPressArena You should upload your theme from here. https://wordpress.org/themes/getting-started/
#19
in reply to:
↑ 17
@chipbennett
10 months ago
Replying to WordPressArena:
@chipbennett
How to commit files to svn: https://themes.svn.wordpress.org/seo-wp/
To elaborate on what @rabmalin said: unfortunately, we cannot upload directly to SVN for Themes, as we can with Plugins. Whenever you have a Theme update, you will need to use the same uploader that you used to upload the Theme originally. The uploader will process the upload, create the SVN files, append/update the open review ticket, etc.
Hello,
Please fix following issues and re-upload your theme.
Previous Issues Not Fixed
Issues