Opened 3 years ago
Closed 3 years ago
#45043 closed task (blessed) (fixed)
Twenty Fifteen: Update theme to add Gutenberg styles and support
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.0 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch, commit, fixed-5.0 |
Focuses: | Cc: |
Description
This ticket is to add Gutenberg styles and support for Twenty Fifteen, so it best takes advantage of the new editor.
For default themes, at the very least this would include adding styles for blocks to make sure they match the rest of the theme’s design, adding Gutenberg-specific editor styles for a better WYSIWYG experience, and adding theme support for the editor color palette.
Each default theme’s unique design should be considered for whether it makes sense to add support for wide alignments, and the best approach.
Attachments (8)
Change History (18)
#2
@
3 years ago
45043.1.patch is based on the original patch, and fixes some minor issues, including making sure the styles are correct for RTL languages. It also fixes an error in code to enqueue fonts into the Gutenberg editor.
Similar to Twenty Sixteen's, the patch adds an editor colour palette based on the theme's different colour schemes (though simplified, since there's a lot of repetition of close shades within individual colour schemes, and across the whole set). I'll include a screenshot below.
This may be more confusing than not to include for Twenty Fifteen and Sixteen, which has a similar custom colour setup, so I'd be interested to know what people think.
#3
@
3 years ago
Hi @laurelfulford! I tested your latest patch. Overall, very solid. Here's what I found:
- Vertical margins on headings seem off in editor vs. front end.
- Recent posts grid view with bullets in editor, but not on the front end.
- Same cover image block issue as here: https://core.trac.wordpress.org/attachment/ticket/45045/cover-image-front-end.png This didn't seem to happen in all cover images.
#4
@
3 years ago
Thanks @davidakennedy!
These should all be fixed in 45043.2.patch! Like in #45044, I also removed some styles in this patch that were for the HTML Block in the editor, which has been updated in the latest version of Gutenberg.
#5
@
3 years ago
45043.3.patch is a really minor update that:
- Updates some of the CSS section headers, for consistency with the other themes, and fixes the order
- Swaps
get_theme_file_uri()
withget_template_directory_uri()
for blocks.css, to make the enqueue format more consistent, and switches the versioning from numbers to date.
#6
@
3 years ago
@laurelfulford This looks good to commit for Beta. Marking it as so in case you can get to it before me today.
I'll keep an eye on #45045 and incorporate anything decided there to the other themes, but since Beta 1 is coming up fast (October 19th), I figured it would be good to get the basic patches posted for the other themes.
45043.patch helps make sure the Gutenberg blocks match Twenty Fifteen's styles on the front-end, and adds styles for the editor.
I'm also attaching some screenshots of the editor before and after, since it's the most dramatic change, but if there's anything else specific anyone would like to see here, let me know!