Attachement page for private post type is a 404.

[Toro_Unit]

1. Create Private post type.
2. Create post at the post type.
3. Upload image in the post.
4. See attachment page.
5. 404 the attachment page.

It occurs in 5.6-beta4.
Does not occur in 5.6-beta3.

related #5272 ?

[peterwilsoncc]

@Toro_Unit thank you for the report, I've self assigned this to take a look.

To assist with reproducing the problem, when you get a 404 on the attachment page are you logged in as a user with access to the private post?

Thanks

https://core.trac.wordpress.org/ticket/51776

Starting with some unit tests -- they fail.

[Toro_Unit]

@peterwilsoncc

To assist with reproducing the problem, when you get a 404 on the attachment page are you logged in as a user with access to the private post?

Yes, Whether logged in or not, get a 404.

Thanks.

[peterwilsoncc]

Thanks boss, much appreciated!

You're correct, the issue comes from #5272. The use of get_post_status() in the new check in redirect_canonical() is causing part of the issue but I am still to get my full notes worked out on the issue. I will drop them here once I have them.

[peterwilsoncc]

Having discussed this with @helen, I am going to largely revert the changes for #5272 as RC1 is due quite soon.

The patch is in the pull request ​https://github.com/WordPress/wordpress-develop/pull/745

[peterwilsoncc]

In 49622:

Permalinks: Prevent attachment pages 404ing following [49563].

This largely reverts [49563] due to attachment pages returning 404: File not found errors when they use the inherit status.

Permalink changes to attachment pages are retained when they are descendants of trashed or deleted posts.

Props Toro_Unit, helen, johnbillion, peterwilsoncc.
Fixes #51776.
See #5272.