THEME: Visualize – 1.1.4

[celloexpressions]

Visualize - 1.1

Visualize is a minimalist two-column theme that places equal emphasis on text and images. Perfect for pairing poetry with photography, illustrations with essays, or showcasing mixed-media works, Visualize features a clean and simple design showcasing an elegant layout. The dramatic site header on the front page features a full-screen video or image of your choice, with three beautiful photo header options included with the theme. Add a custom logo, your site title and tagline, and a menu to round out the header, or dive right into the two-column content. Your content takes center stage with the two-column layout used for all posts and pages, as well as in comment areas. Add widgets to the footer to incorporate additional functionality into your site. Visualize showcases your content through a simple and unique design, providing a site experience that your visitors are sure to enjoy.

Theme URL - ​http://themes.halsey.co/visualize
Author URL - ​https://celloexpressions.com/

Trac Browser - https://themes.trac.wordpress.org/browser/visualize/1.1

SVN - ​https://themes.svn.wordpress.org/visualize/1.1
ZIP - ​https://wordpress.org/themes/download/visualize.1.1.zip?nostats=1

History:

Ticket	Summary	Status	Resolution	Owner
#70964	THEME: Visualize – 1.1.4	closed	live	tskk
(this ticket)
#76091	THEME: Visualize – 1.2	closed	live	themetracbot
#90349	THEME: Visualize – 1.3	closed	live	themetracbot

Theme Check Results:

• RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.

[williampatton]

Hey @celloexpressions,

I was taking a quick look at this theme today and I ran into an issue with a missing function in the content-page.php file at line 12. Missing visualize_content_in_columns() function.

[trtmessenger]

Theme Review Team added some new guidelines on the existing guidelines. So, update your theme based on the added new guidelines.

First see the meeting notes here, ​https://make.wordpress.org/themes/2019/07/09/meeting-notes-from-the-9th-of-july-2019/

The main decision was for skip links, dummy data and Theme generated notices. See the meeting notes above to know more about it.

If you are unaware about skip links please see this, ​https://make.wordpress.org/themes/2019/07/14/how-to-add-and-test-skip-links/

Please update your theme as well as existing themes(if have in the repository.) All the new and existing themes should follow this guidelines.

Thank you

[poena]

@celloexpressions Hi! Do you plan to submit an update?
When issues are found, we expect updates within 7 days, or tickets may be closed due to inactivity. It has now been 3 weeks.

[celloexpressions]

Sorry about the delay; I did not receive email notifications for any of the comments here.

This theme already includes skip links (as well as the other accessibility-ready requirements), doesn't include dummy data, and does not generate any notices. I will push an update to resolve the call to a missing function shortly (thanks for noticing that).

[themetracbot]

Visualize - 1.1.1

Visualize is a minimalist two-column theme that places equal emphasis on text and images. Perfect for pairing poetry with photography, illustrations with essays, or showcasing mixed-media works, Visualize features a clean and simple design showcasing an elegant layout. The dramatic site header on the front page features a full-screen video or image of your choice, with three beautiful photo header options included with the theme. Add a custom logo, your site title and tagline, and a menu to round out the header, or dive right into the two-column content. Your content takes center stage with the two-column layout used for all posts and pages, as well as in comment areas. Add widgets to the footer to incorporate additional functionality into your site. Visualize showcases your content through a simple and unique design, providing a site experience that your visitors are sure to enjoy.

Theme URL - ​http://themes.halsey.co/visualize
Author URL - ​https://celloexpressions.com/

Trac Browser - https://themes.trac.wordpress.org/browser/visualize/1.1.1
WordPress.org - ​https://wordpress.org/themes/visualize/

SVN - ​https://themes.svn.wordpress.org/visualize/1.1.1
ZIP - ​https://wordpress.org/themes/download/visualize.1.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=visualize/1.1&new_path=visualize/1.1.1

History:

Ticket	Summary	Status	Resolution	Owner
#70964	THEME: Visualize – 1.1.4	closed	live	tskk
(this ticket)
#76091	THEME: Visualize – 1.2	closed	live	themetracbot
#90349	THEME: Visualize – 1.3	closed	live	themetracbot

Theme Check Results:

• RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.

[tskk]

Hi, Review will be up in a few hours.

[tskk]

Required:

There is no page navigation on list of posts to go to prev/next list of posts. I can see it in customizer but not in actual site, my guess is the link is hidden behind the fixed post featured image of last post.
Menu shows dropdown icon but there is no dropdown.
Bundled Images are by Nick Halsey, Copyright 2019. should also say licensed under GPL

function visualize_excerpt_more( $more ) {
	global $post;
	return '&hellip;<div><a class="excerpt-more button" href="' . get_permalink( $post->ID ) . '">Read more &rarr;</a></div>';//@todo screen reader text for title
}
add_filter( 'excerpt_more', 'visualize_excerpt_more' );

read more needs translation.

In customizer.php you have to escape the theme mods in visualize_custom_color_css()

Image url's need to be escaped in visualize_post_thumbnail_style(), visualize_post_thumbnail_img, visualize_gallery_excerpt()

Dynamic content in visualize_footer_credits() needs escaping.

[themetracbot]

Visualize - 1.1.2

Visualize is a minimalist two-column theme that places equal emphasis on text and images. Perfect for pairing poetry with photography, illustrations with essays, or showcasing mixed-media works, Visualize features a clean and simple design showcasing an elegant layout. The dramatic site header on the front page features a full-screen video or image of your choice, with three beautiful photo header options included with the theme. Add a custom logo, your site title and tagline, and a menu to round out the header, or dive right into the two-column content. Your content takes center stage with the two-column layout used for all posts and pages, as well as in comment areas. Add widgets to the footer to incorporate additional functionality into your site. Visualize showcases your content through a simple and unique design, providing a site experience that your visitors are sure to enjoy.

Theme URL - ​http://themes.halsey.co/visualize
Author URL - ​https://celloexpressions.com/

Trac Browser - https://themes.trac.wordpress.org/browser/visualize/1.1.2
WordPress.org - ​https://wordpress.org/themes/visualize/

SVN - ​https://themes.svn.wordpress.org/visualize/1.1.2
ZIP - ​https://wordpress.org/themes/download/visualize.1.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=visualize/1.1.1&new_path=visualize/1.1.2

History:

Ticket	Summary	Status	Resolution	Owner
#70964	THEME: Visualize – 1.1.4	closed	live	tskk
(this ticket)
#76091	THEME: Visualize – 1.2	closed	live	themetracbot
#90349	THEME: Visualize – 1.3	closed	live	themetracbot

Theme Check Results:

• RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.

[celloexpressions]

Thanks for the review @tskk. Version 1.1.2 should address the issues that you noted. Please let me know if you find anything else.

[tskk]

Hi, Please give me a couple of days.

[rabmalin]

Here are few more issues you need to check.

Issues

• REQUIRED: Escape get_the_permalink() and get_permalink() with esc_url().
• REQUIRED: comments.php L26 - Missing singular placeholder, needed for some languages. Ref - https://themes.trac.wordpress.org/browser/twentyseventeen/2.2/comments.php#L34
• REQUIRED: template-tags.php L312 - Escape home_url() with esc_url().
• REQUIRED: archive.php - Use the_archive_title() to display archive title. If you want to customize archive title, then you can use get_the_archive_title filter. Similarly, use the_archive_description() to display archive title.
• RECOMMENDED: comments.php - It is recommended to use the_comments_navigation(). See ​https://developer.wordpress.org/reference/functions/the_comments_navigation/

[tskk]

Thanks @rabmalin
@celloexpressions please make those changes and upload new version.

[themetracbot]

Visualize - 1.1.3

Visualize is a minimalist two-column theme that places equal emphasis on text and images. Perfect for pairing poetry with photography, illustrations with essays, or showcasing mixed-media works, Visualize features a clean and simple design showcasing an elegant layout. The dramatic site header on the front page features a full-screen video or image of your choice, with three beautiful photo header options included with the theme. Add a custom logo, your site title and tagline, and a menu to round out the header, or dive right into the two-column content. Your content takes center stage with the two-column layout used for all posts and pages, as well as in comment areas. Add widgets to the footer to incorporate additional functionality into your site. Visualize showcases your content through a simple and unique design, providing a site experience that your visitors are sure to enjoy.

Theme URL - ​http://themes.halsey.co/visualize
Author URL - ​https://celloexpressions.com/

Trac Browser - https://themes.trac.wordpress.org/browser/visualize/1.1.3
WordPress.org - ​https://wordpress.org/themes/visualize/

SVN - ​https://themes.svn.wordpress.org/visualize/1.1.3
ZIP - ​https://wordpress.org/themes/download/visualize.1.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=visualize/1.1.2&new_path=visualize/1.1.3

History:

Ticket	Summary	Status	Resolution	Owner
#70964	THEME: Visualize – 1.1.4	closed	live	tskk
(this ticket)
#76091	THEME: Visualize – 1.2	closed	live	themetracbot
#90349	THEME: Visualize – 1.3	closed	live	themetracbot

Theme Check Results:

• RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.

[celloexpressions]

Thank you @rabmalin - your comments should all be addressed in version 1.1.3. @tskk please let me know if you find anything else, other than the accessibility review.

[tskk]

@celloexpressions I will be able to take a look on Sunday.

[tskk]

All issues fixed, except one tiny one, which you can fix while you wait for accessibility review :

esc_attr( esc_url( home_url() ) ) should be esc_url( home_url() )

[celloexpressions]

Thanks, @tskk - that adjustment has been made and will be included in the next update with any fixes based on the accessibility review.

[williampatton]

Hi @celloexpressions,

I have gone through the list of required accessibility guidelines and tested them against your theme. I found no major issues, just a few minor notes. I am pasting all my notes below however I will mark the ones in bold that are notes for you to look at. The other ones are just to confirm I performed the checks and they were passes :)

Keyboard Navigation:

No issues navigating through pages with only keyboard.

Controls:

Controls in general are easily distinguished and clear when active/focused.

Skip Links:

Skip link is present and functional,

Forms:

Forms have clear focus styles, labels are present.

Headings:

Headings look to be set as H1s for the most part. Could we downgrade some titles (possibly the post titles when shown in lists and the site title on single pages) so that there are more likely to follow a clearer hierarchy?

ARIA Landmark roles:

Content all appears inside a role and all roles look to be used appropriately.

There are several navigation roles. When more than one of the same role is used they should have labels added to disambiguate.

Content Links:

Links have clear focus styles, are underlined within the content.

Repetitive Link Text:

There are not many places that a repetitive link text could appear, this one does pass.

My only note is to maybe look at the text that is displayed for galleries where See More could potentially repeat without additional context.

Contrasts:

Color contrasts are ok. Tested on various pages using Lighthouse.

Images:

Image use looks good. Presentational images are marked as such, featured images have alts.

Media:

There is no special media displays (such as sliders) to test.

Screen Reader Text:

Use of screen reader texts seems fine.

Not Allowed:

Found none of the items that are in the disallowed list.

[themetracbot]

Visualize - 1.1.4

Visualize is a minimalist two-column theme that places equal emphasis on text and images. Perfect for pairing poetry with photography, illustrations with essays, or showcasing mixed-media works, Visualize features a clean and simple design showcasing an elegant layout. The dramatic site header on the front page features a full-screen video or image of your choice, with three beautiful photo header options included with the theme. Add a custom logo, your site title and tagline, and a menu to round out the header, or dive right into the two-column content. Your content takes center stage with the two-column layout used for all posts and pages, as well as in comment areas. Add widgets to the footer to incorporate additional functionality into your site. Visualize showcases your content through a simple and unique design, providing a site experience that your visitors are sure to enjoy.

Theme URL - ​http://themes.halsey.co/visualize
Author URL - ​https://celloexpressions.com/

Trac Browser - https://themes.trac.wordpress.org/browser/visualize/1.1.4
WordPress.org - ​https://wordpress.org/themes/visualize/

SVN - ​https://themes.svn.wordpress.org/visualize/1.1.4
ZIP - ​https://wordpress.org/themes/download/visualize.1.1.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=visualize/1.1.3&new_path=visualize/1.1.4

History:

Ticket	Summary	Status	Resolution	Owner
#70964	THEME: Visualize – 1.1.4	closed	live	tskk
(this ticket)
#76091	THEME: Visualize – 1.2	closed	live	themetracbot
#90349	THEME: Visualize – 1.3	closed	live	themetracbot

Theme Check Results:

• RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.

[celloexpressions]

Thanks for the review @williampatton.

Version 1.1.4 includes the following adjustments:

1. Add aria-labels to elements with role="navigation", and remove a redundant h1 within the posts navigation.
2. Add context to gallery "see more" links.
3. The site title and description are only headings on the front page. Post titles remain h1 typically, as the intent is to include full posts rather than excerpts on archive views and the editor encourages the use of h2 within the content.
4. Add a separate search template and show excerpts with h2 for post titles on search pages.

Please let me know if anything else is required to complete the review process.

[williampatton]

Hi @celloexpressions,

Thanks for getting to these for me (on a Sunday as well!!). Updates seem to have resolved my notes and theme has received a full review previously from @tskk so I am setting this theme live.

Thank you for sharing your themes here in the directory (and especially thank you for ensuring that it gets the accessibility-ready tag :) ).

Setting live, should be there within 20 minutes.

[williampatton]

Hey again, I did have 1 additional thing to mention. This is not actually a problem with your theme so you don't need to do anything about it but still wanted to point it out in case users report it to you in future without any good indication why it happens.

On sites that do not have loopback configured correctly (one of my test sites does not) the getimagesize() function fails. Looks like you use that function in this theme to ensure the featured images are present and correctly sized.

Of course the problem is that I do not have my server configured correctly here so if users report this to you in future you know why :)

[celloexpressions]

Thank you all for the thorough review. I'm looking forward to making more accessibility-ready themes available on the directory -- time to start on the next one!