Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Fix license icon spacing #259

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Fix license icon spacing #259

merged 1 commit into from
Sep 23, 2021

Conversation

zackkrida
Copy link
Member

Fixes

Fixes #258 by @zackkrida

Description

Improves the spacing of icons in the Audio track row.

Technical details

Tests

Screenshots

CleanShot 2021-09-23 at 12 09 32@2x

CleanShot 2021-09-23 at 12 09 24@2x

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@zackkrida zackkrida requested a review from a team as a code owner September 23, 2021 16:11
@zackkrida zackkrida requested review from krysal, AetherUnbound and dhruvkb and removed request for AetherUnbound September 23, 2021 16:11
@zackkrida zackkrida added ✨ goal: improvement Improvement to an existing user-facing feature 🕹 aspect: interface Concerns end-users' experience with the software labels Sep 23, 2021
@zackkrida zackkrida changed the title Fix license icon spacing 258 Fix license icon spacing Sep 23, 2021
@zackkrida
Copy link
Member Author

@dhruvkb I've gotten the approval on this spacing from Francisco 👍 Please review when you can!

Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zackkrida zackkrida merged commit 32120f5 into main Sep 23, 2021
@zackkrida zackkrida deleted the fix-license-icons branch September 23, 2021 19:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Audio row icon spacing issues
3 participants