Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Move import of mixins to embedded layouts #206

Merged
merged 2 commits into from
Sep 15, 2021
Merged

Move import of mixins to embedded layouts #206

merged 2 commits into from
Sep 15, 2021

Conversation

krysal
Copy link
Member

@krysal krysal commented Sep 10, 2021

Description

As mentioned in the title, this PR moves the imports of mixins of each page to the embedded and embedded-with-nav-search layouts, as they're oriented to handle aspects related to the embedded version of Openverse in wp.org. This will save us some lines of code repetition and will be easier to apply changes to corresponding pages in the future, if required.

Tests

Repeating the same steps for Sync locale... #204 and check that it works the same way.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@krysal krysal requested a review from a team as a code owner September 10, 2021 21:28
@dhruvkb dhruvkb added this to Needs review in Openverse Sep 10, 2021
@krysal krysal added ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🕹 aspect: interface Concerns end-users' experience with the software and removed 🕹 aspect: interface Concerns end-users' experience with the software labels Sep 14, 2021
@krysal
Copy link
Member Author

krysal commented Sep 14, 2021

I added a small fix to center the input form on the main search page. In English, it was not noticeable that it was not aligned to the center but in other languages it's more obvious.

Before

Screen Shot 2021-09-14 at 3 48 39 PM

After

Screen Shot 2021-09-14 at 3 49 01 PM

Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a great idea to move the code to layouts and the implementation is equally great.

Openverse automation moved this from Needs review to Reviewer approved Sep 15, 2021
@krysal krysal merged commit 792a99c into main Sep 15, 2021
@krysal krysal deleted the layouts_with_mixins branch September 15, 2021 13:19
Openverse automation moved this from Reviewer approved to Done! Sep 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature
Projects
No open projects
Openverse
  
Done!
Development

Successfully merging this pull request may close these issues.

None yet

3 participants