Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Define and document the MediaTag component #136

Merged
merged 7 commits into from
Aug 24, 2021
Merged

Define and document the MediaTag component #136

merged 7 commits into from
Aug 24, 2021

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Aug 19, 2021

Please merge #127 before this

Description

This PR adds the MediaTag component that represents one tag associated with a media item.

Screenshots

media-tag

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb added this to In progress in Openverse Aug 19, 2021
@dhruvkb dhruvkb marked this pull request as ready for review August 19, 2021 07:25
@dhruvkb dhruvkb requested a review from a team as a code owner August 19, 2021 07:25
@dhruvkb dhruvkb requested review from zackkrida and krysal and removed request for a team August 19, 2021 07:25
@dhruvkb dhruvkb moved this from In progress to Needs review in Openverse Aug 19, 2021
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, just a few things:

  • We should only have a hover state if the element is a link/button/etc. these can also potentially be used just to display a non-interactive tag.
  • All hover styles should also apply on focus
  • The hover state is not documented and I discussed a bit with @panchovm, the final hover state would more likely be dark grey background with light text.

@fcoveram
Copy link

We don't plan to use this component as a link to filter/navigate the search results, so we should not have the link states. This might change, but I suggest keeping it as simple as possible. I'm tasked with the single result mockup where this element will be.

Base automatically changed from track to audio August 19, 2021 23:05
@dhruvkb dhruvkb requested a review from zackkrida August 20, 2021 04:39
Openverse automation moved this from Needs review to Reviewer approved Aug 20, 2021
@dhruvkb dhruvkb merged commit 4d208ec into audio Aug 24, 2021
Openverse automation moved this from Reviewer approved to Done! Aug 24, 2021
@dhruvkb dhruvkb deleted the tags branch August 24, 2021 04:04
@zackkrida zackkrida added the ✨ goal: improvement Improvement to an existing user-facing feature label Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✨ goal: improvement Improvement to an existing user-facing feature
Projects
No open projects
Openverse
  
Done!
Development

Successfully merging this pull request may close these issues.

None yet

4 participants